Skip to content

Commit

Permalink
Remove incorrect dependencies from setup.cfg
Browse files Browse the repository at this point in the history
Remove the `install_requires` on `setuptools`.  This key is used to
specify packages that are needed at runtime.  SCons nowhere in its code
does import `setuptools` or `pkg_resources`.

Remove the `setup_requires` on `build`.  `build` is a frontend package
and a detail of how the build is invoked, while `setup_requires` are
used to specify backend dependencies (i.e. packages that are installed
after `build` is invoked).

Remove the `setup_requires` on `setuptools`.  It is a key specific
to setuptools, so for it to be interpreted `setuptools` need to be
installed already.  The actual backend dependency on `setuptools`
is specified in `pyproject.toml`, so the dependency is entirely
redundant.
  • Loading branch information
mgorny committed Nov 20, 2023
1 parent 0265b1a commit e27b28c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
5 changes: 2 additions & 3 deletions CHANGES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@ NOTE: 4.3.0 now requires Python 3.6.0 and above. Python 3.5.x is no longer suppo

RELEASE VERSION/DATE TO BE FILLED IN LATER

From John Doe:

- Whatever John Doe did.
From Michał Górny:
- Remove unecessary dependencies on pypi packages from setup.cfg


RELEASE 4.6.0 - Sun, 19 Nov 2023 17:22:20 -0700
Expand Down
2 changes: 1 addition & 1 deletion RELEASE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ IMPROVEMENTS
PACKAGING
---------

- List changes in the way SCons is packaged and/or released
- Remove unecessary dependencies on pypi packages from setup.cfg

DOCUMENTATION
-------------
Expand Down
4 changes: 0 additions & 4 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@ classifiers =
[options]
zip_safe = False
python_requires = >=3.6
install_requires = setuptools
setup_requires =
setuptools
build
include_package_data = True
packages = find:

Expand Down

0 comments on commit e27b28c

Please sign in to comment.