-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with Local Ospray #2430
base: master
Are you sure you want to change the base?
Build with Local Ospray #2430
Conversation
I made this change so I can use a local build of OSPRay so I can edit and recompile separately, but it looks like it works with prebuilt binaries. We may be able to use this to replace the default action of compiling OSPRay from scratch with just a simple binary download and link. We also wouldn't need to fork and edit for each version release. |
This would be very useful. |
@@ -46,7 +46,7 @@ using namespace Render; | |||
using namespace Core::Datatypes; | |||
using namespace Core::Geometry; | |||
|
|||
#ifdef WITH_OSPRAY | |||
#if defined(WITH_OSPRAY) || defined(WITH_OSPRAY_LOCAL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you define this disjunction in CMake? Then no C++ files need to change.
WITH_OSPRAY --> BUILD_OSPRAY
WITH_OSPRAY_LOCAL --> PREBUILT_OSPRAY
Then add cmake for WITH_OSPRAY = BUILD_OSPRAY || PREBUILT_OSPRAY
A few cmake files will need to change, but no C++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I'll get this changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarkpate I could handle this change if you are too busy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated with these new flags
I added a CMake flag that searches for a prebuilt version of OSPRay. You just download and add the directory to the path. Also added instructions in the doc.