Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add active language code to requests #19669

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

fix: add active language code to requests #19669

wants to merge 5 commits into from

Conversation

Matejk00
Copy link
Contributor

Closes: CXSPA-8797

@Matejk00 Matejk00 requested a review from a team as a code owner November 29, 2024 13:46
@github-actions github-actions bot marked this pull request as draft November 29, 2024 13:46
@Matejk00 Matejk00 marked this pull request as ready for review December 2, 2024 08:52
@cypress Cypress
Copy link

cypress bot commented Dec 2, 2024 •
edited
Loading

spartacus    Run #46141

Run Properties:  status check failed Failed #46141  •  git commit 2d330c907a ℹ️: Merge 3bbdad68529c58415a5e40828432228627739bbc into a4b72abd137d8898669c4d830996...
Project spartacus
Branch Review feature/CXSPA-8797
Run status status check failed Failed #46141
Run duration 46m 14s
Commit git commit 2d330c907a ℹ️: Merge 3bbdad68529c58415a5e40828432228627739bbc into a4b72abd137d8898669c4d830996...
Committer Mateusz Kolasa
View all properties for this run ↗︎
Test results
Tests that failed  Failures 34
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 6
Tests that passed  Passing 87
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

@github-actions github-actions bot marked this pull request as draft December 2, 2024 10:05
@FollowTheFlo FollowTheFlo marked this pull request as ready for review December 2, 2024 18:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft December 2, 2024 18:52
@FollowTheFlo FollowTheFlo marked this pull request as ready for review December 2, 2024 19:27
FollowTheFlo
FollowTheFlo approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@FollowTheFlo FollowTheFlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, also tested successfully with payment, cta and GP.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FollowTheFlo FollowTheFlo FollowTheFlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Matejk00 @FollowTheFlo