Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds test that checks that Core and Container WC clientAPI are the same #4057

Merged
merged 21 commits into from
Dec 20, 2024
Merged

Adds test that checks that Core and Container WC clientAPI are the same #4057

merged 21 commits into from
Dec 20, 2024

Conversation

walmazacn
Copy link
Contributor

Description

Changes proposed in this pull request:

  • adds test that checks that Core and Container WC clientAPI are the same

Related issue(s)

Resolves #3663

@walmazacn walmazacn linked an issue Dec 9, 2024 that may be closed by this pull request
Add test that checks that Core and Container WC clientAPI are the same #3663
Closed
@walmazacn walmazacn marked this pull request as ready for review December 10, 2024 10:34
@JohannesDoberer JohannesDoberer self-assigned this Dec 11, 2024
JohannesDoberer
JohannesDoberer approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

test/e2e-client-api-test-app/cypress/e2e/container-wc.cy.js Outdated Show resolved Hide resolved
test/e2e-client-api-test-app/cypress/e2e/container-wc.cy.js Outdated Show resolved Hide resolved
@walmazacn walmazacn merged commit ac1236b into main Dec 20, 2024
11 checks passed
@walmazacn walmazacn deleted the 3663-test-core-and-container-client-api branch December 20, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees

@JohannesDoberer JohannesDoberer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test that checks that Core and Container WC clientAPI are the same
2 participants
@walmazacn @JohannesDoberer