Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps of website docs #3891

Merged
merged 11 commits into from
Sep 16, 2024
Merged

Update deps of website docs #3891

merged 11 commits into from
Sep 16, 2024

Conversation

VincentUllal
Copy link
Member

Changes proposed in this pull request:

  • fix warnings when building

  • delete unused deps

  • update used deps

Related issue(s)

resolves #3855

@VincentUllal VincentUllal marked this pull request as ready for review September 4, 2024 13:09
@ndricimrr ndricimrr self-assigned this Sep 5, 2024
@ndricimrr ndricimrr changed the title 3855 update deps of website docs Update deps of website docs Sep 6, 2024
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be functional and no error logs. But I saw some UI Changes when running it locally
Screenshot 2024-09-06 at 14 17 42

IT should be like

Screenshot 2024-09-06 at 14 17 49

@ndricimrr
Copy link
Contributor

The indentation I think works fine now.
I was checking the mobile version and saw this
Screenshot 2024-09-13 at 09 41 24

the deployed website though should show the items
Screenshot 2024-09-13 at 09 41 42

Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@ndricimrr ndricimrr merged commit 77157d3 into main Sep 16, 2024
15 checks passed
@ndricimrr ndricimrr deleted the 3855-update-deps-of-website_docs branch September 16, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies website/docs
3 participants