Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old todos #3851

Merged
merged 12 commits into from
Aug 12, 2024
Merged

Remove old todos #3851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2a4f45c
alert ids todo already handled
ndricimrr Aug 8, 2024
4ae0ad6
luigi.navigate.ok is needed to make LuigiClient compatible
ndricimrr Aug 8, 2024
65b9eec
Remove no-context todo
ndricimrr Aug 8, 2024
22da57e
not needed param
ndricimrr Aug 8, 2024
6b3b41e
Merge branch 'main' into resolve-todos-1
ndricimrr Aug 9, 2024
906f4c0
Remove outdated todo replaceersion
ndricimrr Aug 9, 2024
bae2262
Merge branch 'resolve-todos-1' of github.com:SAP/luigi into resolve-t…
ndricimrr Aug 9, 2024
02c8aa0
Remove not needed TODO in cypres test
ndricimrr Aug 9, 2024
979eb53
Remove not needed TODO in cypres test 2
ndricimrr Aug 9, 2024
2f438af
Remove commented out TODO
ndricimrr Aug 9, 2024
9dc1fee
Remove not needed TODO outdate
ndricimrr Aug 9, 2024
d690337
Merge branch 'main' into resolve-todos-1
ndricimrr Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion container/src/LuigiCompoundContainer.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
compound: compoundConfig,
viewUrl: viewurl,
webcomponent: GenericHelperFunctions.checkWebcomponentValue(webcomponent) || true
}; // TODO: fill with sth
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing context

};
if (!thisComponent.getNoShadow()) {
mainComponent.innerHTML=''
const shadow = thisComponent.attachShadow({ mode: "open"});
Expand Down
4 changes: 1 addition & 3 deletions container/src/services/container.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,15 +107,14 @@ export class ContainerService {
msg: LuigiInternalMessageID.SEND_CONTEXT_HANDSHAKE,
context: targetCnt.context || {},
internal: {},
authData: targetCnt.authData || {},
authData: targetCnt.authData || {}
},
'*'
);
break;
case LuigiInternalMessageID.NAVIGATION_REQUEST:
this.dispatch(Events.NAVIGATION_REQUEST, targetCnt, event.data.params);
break;
// TODO 1: handle alerts with ids on next iteration
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already handled

case LuigiInternalMessageID.ALERT_REQUEST:
this.dispatch(Events.ALERT_REQUEST, targetCnt, event);
break;
Expand Down Expand Up @@ -164,7 +163,6 @@ export class ContainerService {
case LuigiInternalMessageID.GET_CURRENT_ROUTE_REQUEST:
this.dispatch(Events.GET_CURRENT_ROUTE_REQUEST, targetCnt, event);
break;
// TODO: discuss if actually needed as the only scenario is when microfrontend initially starts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed as it needs to fit to existing LuigiClient

case LuigiInternalMessageID.NAVIGATION_COMPLETED_REPORT:
this.dispatch(Events.NAVIGATION_COMPLETED_REPORT, targetCnt, event);
break;
Expand Down
2 changes: 1 addition & 1 deletion container/src/services/webcomponents.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ export class WebComponentService {

if (wc.__postProcess) {
const url =
new URL(document.baseURI).origin === new URL(viewUrl, document.baseURI).origin // TODO: check if needed
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of context

new URL(document.baseURI).origin === new URL(viewUrl, document.baseURI).origin
? new URL('./', new URL(viewUrl, document.baseURI))
: new URL('./', viewUrl);
wc.__postProcess(ctx, clientAPI, url.origin + url.pathname);
Expand Down
1 change: 0 additions & 1 deletion core/src/App.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,6 @@
msg: 'luigi.ux.alert.hide',
id,
dismissKey
//TODO: update docu for this param
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated from long time ago

};
IframeHelpers.sendMessageToIframe(iframe, message);
} else if (alert.promise) {
Expand Down
19 changes: 0 additions & 19 deletions scripts/tools/release-cli/release-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,19 +119,6 @@ function addToChangelog(versionText, changelog, lastline) {
logHeadline('Appended changelog');
}

// function replaceInAllFiles(search, replace) {
// try {
// // TODO: Getting errors while it is working fine from command line. Seems node cannot handle pipes while evaluating commands.
// require('child_process').execSync(
// `cd ${__dirname} && ./replaceInAllFiles.sh "${search}" "${replace}"`,
// { stdio: [0, 1, 2] }
// );
// logHeadline('\nReplaced version in files.');
// } catch (error) {
// logError('Replace error:', error);
// }
// }

/**
* PROMPT
*/
Expand Down Expand Up @@ -233,12 +220,6 @@ function addToChangelog(versionText, changelog, lastline) {
}
} // end if changelog

/**
* REPLACE VERSION IN FILES
*/
// TODO: disabled due to runtime errors and added as console log
// replaceInAllFiles('NEXTRELEASE', `${input.version}`);

/**
* UPDATE PACKAGE-LOCKS
* Skip when running in ci for nightly.
Expand Down
10 changes: 0 additions & 10 deletions test/e2e-test-application/cypress/e2e/tests/0-js-test-app/js-test-app-theming.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,11 +324,6 @@ describe('JS-TEST-APP 2', () => {
.openAsModal('/home/one');
});

// TODO - Accessing LuigiCLient directly results in flaky behavoir, skip for now
// cy.getModalWindow().then(win => {
// assert.deepEqual(win.LuigiClient.getNodeParams(), { mp: 'one' });
// });

cy.expectPathToBe('/home?mymodal=' + encodeURIComponent('/home/one?~mp=one'));
});

Expand All @@ -346,11 +341,6 @@ describe('JS-TEST-APP 2', () => {
.openAsModal('/home/one');
});

// TODO - Accessing LuigiCLient directly results in flaky behavoir, skip for now
// cy.getModalWindow().then(win => {
// assert.deepEqual(win.LuigiClient.getNodeParams(), { mp: 'one' });
// });

cy.expectPathToBe('/home');
cy.location().should(location => {
expect(location.search).to.eq('?mymodal=' + encodeURIComponent('/home/one?~mp=one'));
Expand Down