Fix NextJS example #3540
Merged
Fix NextJS example #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndricimrr
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
VincentUllal and
camelCaseChris
as code owners
Co-authored-by: Aleksandra Simeonova <[email protected]>
alexandra-simeonova
approved these changes
Nov 24, 2023
JohannesDoberer
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Using LuigiClient in production mode in NextJS is not straightforward due to its server-side rendering.
Even if client side code is included in client side react hooks (useEffect), apparently NextJS's internal webpack config mess with the LuigiClient bundle, resulting in LuigiClient bundle errors.
Current solution avoids webpack and includes the LuigiClient bundle directly into the html of the separate NextJS microfronted.
Related issue(s)
Fixes #3500