Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getUserSettings for webcomponents #3414

Merged
merged 21 commits into from
Sep 19, 2023
Merged

Add getUserSettings for webcomponents #3414

merged 21 commits into from
Sep 19, 2023

Conversation

JohannesDoberer
Copy link
Contributor

Fixes #3403

@JohannesDoberer JohannesDoberer added container enhancement New feature or request labels Aug 29, 2023
@JohannesDoberer JohannesDoberer marked this pull request as ready for review August 29, 2023 19:34
@JohannesDoberer JohannesDoberer added the documentation documentation tasks label Sep 4, 2023
@ndricimrr ndricimrr self-assigned this Sep 5, 2023
ndricimrr
ndricimrr reviewed Sep 11, 2023
View reviewed changes
core/src/App.svelte Outdated Show resolved Hide resolved
ndricimrr
ndricimrr approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the comments added looks good. Also tried it out and works as expected.

@JohannesDoberer JohannesDoberer merged commit 8c70f31 into main Sep 19, 2023
11 checks passed
@JohannesDoberer JohannesDoberer deleted the getUserSettings-wc-luigi-client branch September 19, 2023 20:25
@JohannesDoberer JohannesDoberer mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

Assignees

@ndricimrr ndricimrr

Labels
container documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getUserSettings for WC LuigiClient
3 participants
@JohannesDoberer @ndricimrr @alexandra-simeonova