Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getPathParams, getCoreSearchParams, getClientPermissions #3390

Merged
merged 58 commits into from
Oct 6, 2023
Merged

Add getPathParams, getCoreSearchParams, getClientPermissions #3390

merged 58 commits into from
Oct 6, 2023

Conversation

ndricimrr
Copy link
Contributor

@ndricimrr ndricimrr commented Aug 8, 2023 •
edited
Loading

Description

Changes proposed in this pull request:
Adds:

  • getPathParams
  • getCoreSearchParams
  • getClientPermissions

for both container and core

Related issue(s)

Fixes #3387

@ndricimrr
Copy link
Contributor Author

#3365

@ndricimrr ndricimrr added the documentation documentation tasks label Aug 25, 2023
@ndricimrr ndricimrr marked this pull request as ready for review August 25, 2023 15:04
JohannesDoberer
JohannesDoberer reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an error on core/client side when I click on 'getClientPermissions':
Bildschirmfoto 2023-08-28 um 20 08 35

In addition I'm getting for all three functions errors when it comes to compound context:
Bildschirmfoto 2023-08-28 um 20 14 49

JohannesDoberer
JohannesDoberer approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ndricimrr
ndricimrr commented Oct 6, 2023
View reviewed changes
core/src/Modal.svelte Outdated Show resolved Hide resolved
@ndricimrr ndricimrr merged commit 25e36cb into main Oct 6, 2023
12 checks passed
@ndricimrr ndricimrr deleted the 3387-add-more-apis branch October 6, 2023 14:29
@JohannesDoberer JohannesDoberer mentioned this pull request Oct 18, 2023
Merged
@ndricimrr ndricimrr removed the enhancement New feature or request label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

Assignees

@JohannesDoberer JohannesDoberer

Labels
container documentation documentation tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getPathParams, getCoreSearchParams, getClientPermissions
3 participants
@ndricimrr @JohannesDoberer @alexandra-simeonova