implement comments

SAP · Aug 23, 2024 · e438485 · e438485
1 parent 922b83a
commit e438485
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 29 deletions.
diff --git a/container/cypress/e2e/test-app/iframe/iframe-container.cy.js b/container/cypress/e2e/test-app/iframe/iframe-container.cy.js
@@ -24,28 +24,16 @@ describe('Iframe Container Test', () => {
   });
 
   it('sendCustomMessage', () => {
+    cy.get('#btn-1')
+      .click()
     cy.get(containerSelector)
       .shadow()
       .get('iframe')
       .then(iframe => {
         const $body = iframe.contents().find('body')
         cy.wrap($body)
           .find('#content')
-          .should('have.text', ' ');
-      });
-
-    cy.get('#btn-1')
-      .click()
-      .then(() => {
-        cy.get(containerSelector)
-          .shadow()
-          .get('iframe')
-          .then(iframe => {
-            const $body = iframe.contents().find('body')
-            cy.wrap($body)
-              .find('#content')
-              .should('have.text', 'Received Custom Message: some data');
-          });
+          .should('have.text', 'Received Custom Message: some data');
       });
   });
 

diff --git a/container/cypress/e2e/test-app/wc/wc-container.cy.js b/container/cypress/e2e/test-app/wc/wc-container.cy.js
@@ -132,19 +132,14 @@ describe('Web Container Test', () => {
         });
     });
     it('sendCustomMessage', () => {
+      cy.get('#sendCustomMessageBtn')
+        .click()
+
       cy.get(containerSelector)
         .shadow()
         .find('#customMessageDiv')
-        .should('have.text', 'Received Custom Message: ');
+        .should('have.text', 'Received Custom Message: cool custom Message');
 
-      cy.get('#sendCustomMessageBtn')
-        .click()
-        .then(() => {
-          cy.get(containerSelector)
-            .shadow()
-            .find('#customMessageDiv')
-            .should('have.text', 'Received Custom Message: cool custom Message');
-        });
     });
   });
 });
diff --git a/container/test-app/wc/clientAPI.html b/container/test-app/wc/clientAPI.html
@@ -10,16 +10,12 @@ <h3>
       component based microfrontend
     </h3>
     <button id="luigi-update-context" type="button">Update context</button>
-    <button id="init-button" style="margin: 25px 0 15px">
-      container.init() to initialize defered container
-    </button>
     <button id="sendCustomMessageBtn" style="margin: 25px 0 15px">sendCustomMessage</button>
 
     <div style="height: fit-content;">
       <div style="border: 1px solid blue">
         <!-- Luigi Container to test general functionalities, params etc-->
         <luigi-container
-          id="test-id"
           data-test-id="luigi-client-api-test-01"
           viewURL="./wc/helloWorldWC.js"
           webcomponent="true"
@@ -38,6 +34,9 @@ <h3>
         ></luigi-container>
       </div>
 
+      <button id="init-button" style="margin: 25px 0 15px">
+        container.init() to initialize defered container
+      </button>
       <div style="border: 1px solid red">
         <!-- Luigi Container to test defer-init flag-->
 
@@ -71,7 +70,7 @@ <h3>
         deferInitContainer.init();
       });
       // document.querySelector('luigi-container');
-      const container = document.getElementById('test-id');
+      const container = document.querySelector('[data-test-id="luigi-client-api-test-01"]')
       const sendCustomMsgBtn = document.getElementById('sendCustomMessageBtn');
       sendCustomMsgBtn.addEventListener('click', () => {
         container.sendCustomMessage('custom-message-id', {dataToSend: 'cool custom Message'});