Adds missing icon in alert (#3822)

SAP · Jul 18, 2024 · 919367e · 919367e
1 parent 42c9d0d
commit 919367e
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 0 deletions.
diff --git a/core/src/Alerts.svelte b/core/src/Alerts.svelte
@@ -108,6 +108,14 @@
       id="j2ALl423"
       data-testid="luigi-alert"
     >
+      <div class="fd-message-strip__icon-container" aria-hidden="true">
+        <span
+          class="sap-icon sap-icon--message-{alertTypeMap[al.settings.type]}"
+          focusable="false"
+          role="presentation"
+          aria-hidden="true"
+        />
+      </div>
       <p class="fd-message-strip__text">
         {@html al.dataSanitized ? al.settings.text : ''}
       </p>

diff --git a/test/e2e-test-application/cypress/e2e/test2/1-angular/external-micro-frontend.cy.js b/test/e2e-test-application/cypress/e2e/test2/1-angular/external-micro-frontend.cy.js
@@ -7,6 +7,9 @@ describe('Navigation', () => {
     it('Check if external micro frontend is available and an alert will be shown.', () => {
       cy.visit('/projects/pr1/externalmf');
       cy.get('[data-testid=luigi-alert]', { timeout: 5000 }).should('have.class', 'fd-message-strip--success');
+      cy.get('[data-testid=luigi-alert]', { timeout: 5000 })
+        .find('.fd-message-strip__icon-container span')
+        .should('have.class', 'sap-icon--message-success');
       cy.get('[data-testid=luigi-alert]', { timeout: 5000 }).contains(
         'This is just a test alert for external micro frontend.'
       );

diff --git a/.../e2e-test-application/cypress/e2e/tests/1-angular/i18n-context-product-app-switcher.cy.js b/.../e2e-test-application/cypress/e2e/tests/1-angular/i18n-context-product-app-switcher.cy.js
@@ -42,6 +42,9 @@ describe('Context switcher', () => {
       .and('contain', 'Project 5');
 
     cy.get('[data-testid=luigi-alert]').should('have.class', 'fd-message-strip--information');
+    cy.get('[data-testid=luigi-alert]')
+      .find('.fd-message-strip__icon-container span')
+      .should('have.class', 'sap-icon--message-information');
 
     cy.get('[data-testid=luigi-alert]').should('contain', 'Project 5 created.');
 

diff --git a/...e2e-test-application/cypress/e2e/tests/1-angular/luigi-client-link-manager-features.cy.js b/...e2e-test-application/cypress/e2e/tests/1-angular/luigi-client-link-manager-features.cy.js
@@ -115,6 +115,9 @@ describe('Luigi client linkManager', () => {
         .eq(0)
         .click();
       cy.get('[data-testid=luigi-alert]').should('have.class', 'fd-message-strip--information');
+      cy.get('[data-testid=luigi-alert]')
+        .find('.fd-message-strip__icon-container span')
+        .should('have.class', 'sap-icon--message-information');
       cy.get('[data-testid=luigi-alert]').should('contain', 'Hello from uxManager in Web Component, Language:en');
     });
 

diff --git a/test/e2e-test-application/cypress/e2e/tests/1-angular/luigi-client-ux-alerts-i18n.cy.js b/test/e2e-test-application/cypress/e2e/tests/1-angular/luigi-client-ux-alerts-i18n.cy.js
@@ -24,6 +24,9 @@ describe('Luigi Client UX Alerts + Localization', () => {
         .click();
 
       cy.get('[data-testid=luigi-alert]').should('have.class', 'fd-message-strip--success');
+      cy.get('[data-testid=luigi-alert]')
+        .find('.fd-message-strip__icon-container span')
+        .should('have.class', 'sap-icon--message-success');
 
       cy.get('[data-testid=luigi-alert-dismiss]').click();
       cy.get('[data-testid=luigi-alert]').should('not.exist');
@@ -39,6 +42,9 @@ describe('Luigi Client UX Alerts + Localization', () => {
         .click();
 
       cy.get('[data-testid=luigi-alert]').should('have.class', 'fd-message-strip--information');
+      cy.get('[data-testid=luigi-alert]')
+        .find('.fd-message-strip__icon-container span')
+        .should('have.class', 'sap-icon--message-information');
     });
 
     it('hides Alert after specified time', () => {
@@ -133,6 +139,9 @@ describe('Luigi Client UX Alerts + Localization', () => {
         .click({ force: true });
 
       cy.get('[data-testid=luigi-alert]').should('have.class', 'fd-message-strip--warning');
+      cy.get('[data-testid=luigi-alert]')
+        .find('.fd-message-strip__icon-container span')
+        .should('have.class', 'sap-icon--message-warning');
 
       cy.get('*[id$=_link_relativePath]').click();
       cy.expectPathToBe('/projects/pr1');
@@ -171,6 +180,9 @@ describe('Luigi Client UX Alerts + Localization', () => {
       cy.get('[data-testid=luigi-alert]')
         .should('have.class', 'fd-message-strip--error')
         .should('contain', "<b onmouseover=alert('Wufff!')>click me!</b>");
+      cy.get('[data-testid=luigi-alert]')
+        .find('.fd-message-strip__icon-container span')
+        .should('have.class', 'sap-icon--message-error');
 
       cy.get('[data-testid=luigi-alert]')
         .find('a')

diff --git a/test/e2e-test-application/cypress/e2e/tests/1-angular/navigation.cy.js b/test/e2e-test-application/cypress/e2e/tests/1-angular/navigation.cy.js
@@ -349,6 +349,9 @@ describe('Navigation', () => {
       cy.visit('/projects/pr2/emptyViewUrl');
 
       cy.get('[data-testid=luigi-alert]').should('have.class', 'fd-message-strip--error');
+      cy.get('[data-testid=luigi-alert]')
+        .find('.fd-message-strip__icon-container span')
+        .should('have.class', 'sap-icon--message-error');
       cy.expectPathToBe('/overview');
     });
   });