Resolve TODOs in repo (#3598)

SAP · Feb 1, 2024 · 6572266 · 6572266
1 parent e5f0e80
commit 6572266
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 46 deletions.
diff --git a/...eworks-support/testing-utilities/test/cypress/e2e/0-luigimockengine/mockengine-test.cy.js b/...eworks-support/testing-utilities/test/cypress/e2e/0-luigimockengine/mockengine-test.cy.js
@@ -19,12 +19,6 @@ describe('Luigi Mock Engine', () => {
     it('Check LuigiClient.uxManager().confirmModal', () => {
       cy.get('[id^=uxbutton2]').click();
 
-      //TODO: Check on luigi client side why an error message is returned
-      cy.on('uncaught:exception', (err, runnable) => {
-        // returning false here prevents Cypress from failing the test
-        return false;
-      });
-
       cy.get('[id^="luigi-debug-vis-cnt"]')
         .children()
         .contains('"msg":"luigi.ux.confirmationModal.show"');

diff --git a/core/examples/luigi-example-react/webpack.config.js b/core/examples/luigi-example-react/webpack.config.js
@@ -87,15 +87,6 @@ module.exports = function(webpackEnv) {
       port: 3000,
       open: true
     },
-    optimization: {
-      minimize: true,
-      // todo: Remove after renaming luigi core map files
-      minimizer: [
-        new TerserPlugin({
-          exclude: /\.svelte\.map\.js$/
-        })
-      ]
-    },
     devtool: !isEnvProduction ? 'inline-source-map' : false,
     // Change accordingly on prodcuciton
     performance: {

diff --git a/core/src/Authorization.svelte b/core/src/Authorization.svelte
@@ -379,9 +379,8 @@
     overflow-y: auto;
     padding-left: 0.5rem;
     padding-right: 0.5rem;
-    /*TODO: check if FD Styles > 0.18.0 has fixed it*/
     .fd-list__title {
-      line-height: var(--sapContent_LineHeight, 1.4);
-    }
+      line-height: var(--sapContent_LineHeight);
+    } 
   }
 </style>
diff --git a/core/src/navigation/LeftNav.svelte b/core/src/navigation/LeftNav.svelte
@@ -1184,11 +1184,11 @@
     }
   }
 
-  /*TODO: check if FD Styles >v.0.17 included it*/
-  .lui-category {
-    border-top: var(--sapList_BorderWidth, 0.0625rem) solid
-      var(--sapList_GroupHeaderBorderColor, #d8d8d8);
-  }
+.lui-category {
+  border-top:
+  var(--sapList_BorderWidth) solid
+  var(--sapList_GroupHeaderBorderColor);
+}
 
   .lui-fd-side-nav-wrapper {
     height: 100%;

diff --git a/core/src/navigation/MobileTopNavDropDown.svelte b/core/src/navigation/MobileTopNavDropDown.svelte
@@ -104,11 +104,6 @@
 </div>
 
 <style lang="scss">
-  /* TODO remove after update to fundamental 0.9 */
-  .fd-product-switch__item.selected .fd-product-switch__title:before,
-  .fd-product-switch__item.selected .fd-product-switch__title:after {
-    content: none !important;
-  }
 
   @media (max-width: 1023px) {
     .fd-product-switch__body--mobile {

diff --git a/cra-template/template/webpack.config.js b/cra-template/template/webpack.config.js
@@ -87,15 +87,6 @@ module.exports = function(webpackEnv) {
       port: 3000,
       open: true
     },
-    optimization: {
-      minimize: true,
-      // todo: Remove after renaming luigi core map files
-      minimizer: [
-        new TerserPlugin({
-          exclude: /\.svelte\.map\.js$/
-        })
-      ]
-    },
     devtool: !isEnvProduction ? 'inline-source-map' : false,
     // Change accordingly on prodcuciton
     performance: {

diff --git a/website/fiddle/webpack.config.js b/website/fiddle/webpack.config.js
@@ -68,15 +68,6 @@ module.exports = {
       filename: '[name].css'
     })
   ],
-  optimization: {
-    minimize: true,
-    minimizer: [
-      new TerserPlugin({
-        // TODO: Remove when renaming luigi.svete.map.js to .map filetype
-        exclude: /\.svelte\.map\.js$/
-      })
-    ]
-  },
   devtool: prod ? false : 'source-map',
   stats: {
     errorDetails: true