onNodeActivation async (#3457)

SAP · Oct 9, 2023 · 43c5422 · 43c5422
1 parent 25e36cb
commit 43c5422
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/core/src/navigation/services/navigation.js b/core/src/navigation/services/navigation.js
@@ -454,7 +454,11 @@ class NavigationClass {
   }
 
   async shouldPreventNavigation(node) {
-    if (node && GenericHelpers.isFunction(node.onNodeActivation) && (await node.onNodeActivation(node)) === false) {
+    if (
+      node &&
+      (GenericHelpers.isFunction(node.onNodeActivation) || GenericHelpers.isAsyncFunction(node.onNodeActivation)) &&
+      (await node.onNodeActivation(node)) === false
+    ) {
       return true;
     }
     return false;

diff --git a/core/src/utilities/helpers/generic-helpers.js b/core/src/utilities/helpers/generic-helpers.js
@@ -22,6 +22,15 @@ class GenericHelpersClass {
     return functionToCheck && {}.toString.call(functionToCheck) === '[object Function]';
   }
 
+  /**
+   * Checks if input is an async function.
+   * @param functionToCheck mixed
+   * @returns {boolean}
+   */
+  isAsyncFunction(functionToCheck) {
+    return functionToCheck && {}.toString.call(functionToCheck) === '[object AsyncFunction]';
+  }
+
   /**
    * Checks if input is a promise.
    * @param promiseToCheck mixed