added example object to ILMB folder (#571)

* added example object to ILMB folder * File Renamed to z_aff_example_ilmb.ilmb.json * File renamed and required annotations removed * checkmarx changes failed * Fixing checkmarx issues * Removal of annotations destruction object and callback class * Annotation Changes * Update to ILMB-v1 JSON
SAP · Nov 16, 2023 · a11a09f · a11a09f
1 parent 89a1440
commit a11a09f
Show file tree

Hide file tree

Showing 4 changed files with 69 additions and 6 deletions.
diff --git a/file-formats/ilmb/README.md b/file-formats/ilmb/README.md
@@ -2,4 +2,4 @@
 
 File | Cardinality | Definition | Schema | Example
 :--- | :--- | :--- | :--- | :---
-`<name>.ilmb.json` | 1 | [`zif_aff_ilmb_v1.intf.abap`](./type/zif_aff_ilmb_v1.intf.abap) | [`ilmb-v1.json`](./ilmb-v1.json)
+`<name>.ilmb.json` | 1 |  [`zif_aff_ilmb_v1.intf.abap`](./type/zif_aff_ilmb_v1.intf.abap)  | [`ilmb-v1.json`](./ilmb-v1.json) | [z_aff_example_ilmb.ilmb.json](./examples/z_aff_example_ilmb.ilmb.json)
diff --git a/file-formats/ilmb/examples/z_aff_example_ilmb.ilmb.json b/file-formats/ilmb/examples/z_aff_example_ilmb.ilmb.json
@@ -0,0 +1,67 @@
+{
+  "formatVersion": "1",
+  "header": {
+    "description": "Sample ILM Object (Flight Model)",
+    "originalLanguage": "en"
+  },
+  "timeReferences": [
+    {
+      "timeReference": "CREATION_DATE",
+      "sourceTable": "SFLIGHT",
+      "sourceField": "FLDATE"
+    },
+    {
+      "timeReference": "Z_FIXED_DATE",
+      "sourceTable": "SFLIGHT",
+      "sourceField": "FLDATE",
+      "indirectValue": true
+    }
+  ],
+  "conditionFields": [
+    {
+      "conditionField": "CARRID_1",
+      "dataElement": "S_CARRID",
+      "sourceTable": "SFLIGHT",
+      "sourceField": "CARRID",
+      "noIntervals": true
+    },
+    {
+      "conditionField": "CONNID",
+      "dataElement": "CONNID",
+      "sourceTable": "SFLIGHT",
+      "sourceField": "CONNID",
+      "noIntervals": true
+    },
+    {
+      "conditionField": "COUNTRY",
+      "dataElement": "LAND1",
+      "sourceTable": "SFLIGHT",
+      "sourceField": "CARRID",
+      "indirectValue": true,
+      "noIntervals": true
+    },
+    {
+      "conditionField": "COUNTRY",
+      "dataElement": "LAND1",
+      "sourceTable": "SFLIGHT",
+      "sourceField": "CONNID",
+      "indirectValue": true,
+      "noIntervals": true
+    },
+    {
+      "conditionField": "COUNTRY",
+      "dataElement": "LAND1",
+      "sourceTable": "SFLIGHT",
+      "sourceField": "FLDATE",
+      "indirectValue": true,
+      "noIntervals": true
+    },
+    {
+      "conditionField": "CURRENCY",
+      "dataElement": "S_CURRCODE",
+      "sourceTable": "SFLIGHT",
+      "sourceField": "CURRENCY",
+      "noIntervals": true
+    }
+  ]
+}
diff --git a/file-formats/ilmb/ilmb-v1.json b/file-formats/ilmb/ilmb-v1.json
@@ -190,9 +190,7 @@
   "required": [
     "formatVersion",
     "header",
-    "destructionObject",
     "timeReferences",
-    "conditionFields",
-    "callbackClass"
+    "conditionFields"
   ]
 }
diff --git a/file-formats/ilmb/type/zif_aff_ilmb_v1.intf.abap b/file-formats/ilmb/type/zif_aff_ilmb_v1.intf.abap
@@ -89,7 +89,6 @@ INTERFACE zif_aff_ilmb_v1
       header             TYPE zif_aff_types_v1=>ty_header_60_cloud,
       "! <p class="shorttext">Destruction Object</p>
       "! Mapping ILM object to data destruction object
-      "! $required
       destruction_object TYPE ty_destruction_object,
       "! <p class="shorttext">Time References</p>
       "! Value determination for time references
@@ -101,7 +100,6 @@ INTERFACE zif_aff_ilmb_v1
       condition_fields   TYPE ty_cond_fields,
       "! <p class="shorttext">Value Determination Callback Class</p>
       "! Value determination callback class
-      "! $required
       callback_class     TYPE ty_callback_class,
     END OF ty_main.