This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
modify to send approval task to the manager and confirm tasks to the … #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi colleagues,
I just found that the sample of onboarding only sends user tasks to those who start the workflow instance, which doesn't comply with the workflow definition, and also when we use workflow API to start the workflow then no one can receive the tasks.
According to the scenario "when a new hire onboard, the equipment request first be sent to the buddy to confirm the assigned equipment, and then to the manager to approve, and finally to the buddy to confirm the readiness", I modify the "recipientUsers" of the three user tasks in "onboard.workflow", and modify the corresponding sample data in "SampleInputContext.json".
Please check if my modification can be accepted, and if so please also help to replace the cf-onboarding-sample.zip because plenty of the hands-on/workshops refer to this use case and are required to download the sample code.
Thank you so much!
BR,
Sindy Zhan