Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

modify to send approval task to the manager and confirm tasks to the … #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SidiZhan
Copy link

@SidiZhan SidiZhan commented Jul 8, 2022

Hi colleagues,
I just found that the sample of onboarding only sends user tasks to those who start the workflow instance, which doesn't comply with the workflow definition, and also when we use workflow API to start the workflow then no one can receive the tasks.
According to the scenario "when a new hire onboard, the equipment request first be sent to the buddy to confirm the assigned equipment, and then to the manager to approve, and finally to the buddy to confirm the readiness", I modify the "recipientUsers" of the three user tasks in "onboard.workflow", and modify the corresponding sample data in "SampleInputContext.json".
Please check if my modification can be accepted, and if so please also help to replace the cf-onboarding-sample.zip because plenty of the hands-on/workshops refer to this use case and are required to download the sample code.
Thank you so much!
BR,
Sindy Zhan

@cla-assistant
Copy link

cla-assistant bot commented Jul 8, 2022

CLA assistant check
All committers have signed the CLA.

@SidiZhan
Copy link
Author

SidiZhan commented Jul 8, 2022

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

I505432 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

I have agreed to the CLA with this github account, but when I commit I use sap email so I guess it is the reason why the cla-asisstant bot cannot recognize the completion of check. Does it block the merging?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant