Some improvments (#27)

* Added the data and mime type attributes to the TicketAttachment

* Made some attributes of the Ticket and TicketArticle nullable to not require them at creation

* Some cleanup & exception handling

* Fix ParseAsync automatic & Exception improv.
- Use nameof logic
- Helper function in exception for get response content

* TicketAttachment.CreateFromFile

.editorconfig

@@ -1,194 +1,156 @@
-# Schema: http://EditorConfig.org
-# Docs: https://docs.microsoft.com/en-us/visualstudio/ide/editorconfig-code-style-settings-reference
+# EditorConfig is awesome:http://EditorConfig.org
 
 # top-most EditorConfig file
 root = true
 
 # Don't use tabs for indentation.
 [*]
 indent_style = space
-trim_trailing_whitespace = true
+# (Please don't specify an indent_size here; that has too many unintended consequences.)
 
 # Code files
 [*.{cs,csx,vb,vbx}]
 indent_size = 4
 insert_final_newline = true
-#charset = utf-8-bom
+charset = utf-8-bom
 
 # Xml project files
 [*.{csproj,vbproj,vcxproj,vcxproj.filters,proj,projitems,shproj}]
 indent_size = 2
 
 # Xml config files
-[*.{props,targets,ruleset,config,nuspec,resx,vsixmanifest,vsct,xml,stylecop}]
+[*.{props,targets,ruleset,config,nuspec,resx,vsixmanifest,vsct}]
 indent_size = 2
 
 # JSON files
 [*.json]
 indent_size = 2
 
-# Shell scripts
-[*.sh]
-end_of_line = lf
-
-[*.{cmd,bat}]
-end_of_line = crlf
-
-## Language conventions
 # Dotnet code style settings:
 [*.{cs,vb}]
+# Sort using and Import directives with System.* appearing first
+dotnet_sort_system_directives_first = true
 # Avoid "this." and "Me." if not necessary
-dotnet_style_qualification_for_event = false : warning
-dotnet_style_qualification_for_field = false : warning
-dotnet_style_qualification_for_method = false : warning
-dotnet_style_qualification_for_property = false : warning
+dotnet_style_qualification_for_field = false:suggestion
+dotnet_style_qualification_for_property = false:suggestion
+dotnet_style_qualification_for_method = false:suggestion
+dotnet_style_qualification_for_event = false:suggestion
 
 # Use language keywords instead of framework type names for type references
-dotnet_style_predefined_type_for_locals_parameters_members = true : warning
-dotnet_style_predefined_type_for_member_access = true : warning
-
-# Expression-level preferences
-dotnet_style_coalesce_expression = true : warning
-dotnet_style_collection_initializer = true : warning
-dotnet_style_explicit_tuple_names = true : warning
-dotnet_style_null_propagation = true : warning
-dotnet_style_object_initializer = true : warning
-dotnet_style_prefer_is_null_check_over_reference_equality_method = true : warning
-dotnet_style_require_accessibility_modifiers = always : warning
+dotnet_style_predefined_type_for_locals_parameters_members = true:suggestion
+dotnet_style_predefined_type_for_member_access = true:suggestion
 
-# CSharp code style settings:
-[*.cs]
-# Prefer "var" everywhere (Implicit and explicit types)
-csharp_style_var_elsewhere = true : warning
-csharp_style_var_for_built_in_types = true : warning
-csharp_style_var_when_type_is_apparent = true : warning
-
-# Expression-Bodied members
-csharp_style_expression_bodied_accessors = true : warning
-csharp_style_expression_bodied_indexers = true : warning
-csharp_style_expression_bodied_operators = true : warning
-csharp_style_expression_bodied_properties = true : warning
-# Explicitly disabled due to difference in coding style between source and tests
-#csharp_style_expression_bodied_constructors = true : warning
-#csharp_style_expression_bodied_methods = true : warning
-
-# Pattern matching
-csharp_style_pattern_matching_over_as_with_null_check = true : warning
-csharp_style_pattern_matching_over_is_with_cast_check = true : warning
-
-# Inlined variable declarations
-csharp_style_inlined_variable_declaration = true : warning
-
-# Expression-level preferences
-csharp_prefer_inferred_anonymous_type_member_names = true : warning
-csharp_prefer_inferred_tuple_names = true : warning
-csharp_prefer_simple_default_expression = true : warning
-csharp_preferred_modifier_order = public,private,protected,internal,const,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async
-csharp_style_deconstructed_variable_declaration = true : warning
-csharp_style_pattern_local_over_anonymous_function = true : warning
-
-# Null-checking preference
-csharp_style_conditional_delegate_call = true : warning
-csharp_style_throw_expression = true : warning
-
-# Code block preferences
-csharp_prefer_braces = true : warning
-
-## Formatting conventions
-# Dotnet formatting settings:
-[*.{cs,vb}]
-# Organize usings
-dotnet_sort_system_directives_first = true
+# Suggest more modern language features when available
+dotnet_style_object_initializer = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_explicit_tuple_names = true:suggestion
 
-# CSharp formatting settings:
-[*.cs]
-# Newline options
-csharp_new_line_before_catch = true
-csharp_new_line_before_else = true
-csharp_new_line_before_finally = true
-csharp_new_line_before_members_in_anonymous_types = true
-csharp_new_line_before_members_in_object_initializers = true
-csharp_new_line_before_open_brace = all
-csharp_new_line_between_query_expression_clauses = true
+# Non-private static fields are PascalCase
+dotnet_naming_rule.non_private_static_fields_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.non_private_static_fields_should_be_pascal_case.symbols = non_private_static_fields
+dotnet_naming_rule.non_private_static_fields_should_be_pascal_case.style = non_private_static_field_style
 
-# Identation options
-csharp_indent_case_contents = true
-csharp_indent_labels = no_change
-csharp_indent_switch_labels = true
+dotnet_naming_symbols.non_private_static_fields.applicable_kinds = field
+dotnet_naming_symbols.non_private_static_fields.applicable_accessibilities = public, protected, internal, protected internal, private protected
+dotnet_naming_symbols.non_private_static_fields.required_modifiers = static
 
-# Spacing options
-csharp_space_after_cast = false
-csharp_space_after_keywords_in_control_flow_statements = true
-csharp_space_around_binary_operators = before_and_after
-csharp_space_between_method_call_parameter_list_parentheses = false
-csharp_space_between_method_declaration_parameter_list_parentheses = false
-csharp_space_between_parentheses = false
+dotnet_naming_style.non_private_static_field_style.capitalization = pascal_case
 
-# Wrapping options
-csharp_preserve_single_line_blocks = true
-csharp_preserve_single_line_statements = false
+# Constants are PascalCase
+dotnet_naming_rule.constants_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.constants_should_be_pascal_case.symbols = constants
+dotnet_naming_rule.constants_should_be_pascal_case.style = constant_style
 
-## Naming conventions
-[*.{cs,vb}]
+dotnet_naming_symbols.constants.applicable_kinds = field, local
+dotnet_naming_symbols.constants.required_modifiers = const
 
-## Naming styles
+dotnet_naming_style.constant_style.capitalization = pascal_case
+
+# Static fields are camelCase and start with s_
+dotnet_naming_rule.static_fields_should_be_camel_case.severity = suggestion
+dotnet_naming_rule.static_fields_should_be_camel_case.symbols = static_fields
+dotnet_naming_rule.static_fields_should_be_camel_case.style = static_field_style
+
+dotnet_naming_symbols.static_fields.applicable_kinds = field
+dotnet_naming_symbols.static_fields.required_modifiers = static
+
+dotnet_naming_style.static_field_style.capitalization = camel_case
+dotnet_naming_style.static_field_style.required_prefix = s_
+
+# Instance fields are camelCase and start with _
+dotnet_naming_rule.instance_fields_should_be_camel_case.severity = suggestion
+dotnet_naming_rule.instance_fields_should_be_camel_case.symbols = instance_fields
+dotnet_naming_rule.instance_fields_should_be_camel_case.style = instance_field_style
+
+dotnet_naming_symbols.instance_fields.applicable_kinds = field
+
+dotnet_naming_style.instance_field_style.capitalization = camel_case
+dotnet_naming_style.instance_field_style.required_prefix = _
+
+# Locals and parameters are camelCase
+dotnet_naming_rule.locals_should_be_camel_case.severity = suggestion
+dotnet_naming_rule.locals_should_be_camel_case.symbols = locals_and_parameters
+dotnet_naming_rule.locals_should_be_camel_case.style = camel_case_style
+
+dotnet_naming_symbols.locals_and_parameters.applicable_kinds = parameter, local
 
-dotnet_naming_style.pascal_case_style.capitalization = pascal_case
 dotnet_naming_style.camel_case_style.capitalization = camel_case
 
-# PascalCase with I prefix
-dotnet_naming_style.interface_style.capitalization = pascal_case
-dotnet_naming_style.interface_style.required_prefix = I
-
-# camelCase with _ prefix
-dotnet_naming_style._camelCase.capitalization = camel_case
-dotnet_naming_style._camelCase.required_prefix = _
-
-## Rules
-# Interfaces
-dotnet_naming_rule.interface_naming.symbols = interface_symbol
-dotnet_naming_rule.interface_naming.style = interface_style
-dotnet_naming_rule.interface_naming.severity = warning
-dotnet_naming_symbols.interface_symbol.applicable_kinds = interface
-dotnet_naming_symbols.interface_symbol.applicable_accessibilities = *
-
-# Classes, Structs, Enums, Properties, Methods, Events
-dotnet_naming_rule.class_naming.symbols = class_symbol
-dotnet_naming_rule.class_naming.style = pascal_case_style
-dotnet_naming_rule.class_naming.severity = warning
-
-dotnet_naming_symbols.class_symbol.applicable_kinds = class, struct, enum, property, method, event
-dotnet_naming_symbols.class_symbol.applicable_accessibilities = *
-
-# Const fields
-dotnet_naming_rule.const_field_naming.symbols = const_field_symbol
-dotnet_naming_rule.const_field_naming.style = pascal_case_style
-dotnet_naming_rule.const_field_naming.severity = warning
-
-dotnet_naming_symbols.const_field_symbol.applicable_kinds = field
-dotnet_naming_symbols.const_field_symbol.applicable_accessibilities = *
-dotnet_naming_symbols.const_field_symbol.required_modifiers = const
-
-# Public fields
-dotnet_naming_rule.public_field_naming.symbols = public_field_symbol
-dotnet_naming_rule.public_field_naming.style = pascal_case_style
-dotnet_naming_rule.public_field_naming.severity = warning
-
-dotnet_naming_symbols.public_field_symbol.applicable_kinds = field
-dotnet_naming_symbols.public_field_symbol.applicable_accessibilities = public, internal, protected
-
-# Other fields
-dotnet_naming_rule.other_field_naming.symbols = other_field_symbol
-dotnet_naming_rule.other_field_naming.style = _camelCase
-dotnet_naming_rule.other_field_naming.severity = warning
-
-dotnet_naming_symbols.other_field_symbol.applicable_kinds = field
-dotnet_naming_symbols.other_field_symbol.applicable_accessibilities = *
-
-# Everything Else
-dotnet_naming_rule.everything_else_naming.symbols = everything_else
-dotnet_naming_rule.everything_else_naming.style = camel_case_style
-dotnet_naming_rule.everything_else_naming.severity = warning
-
-dotnet_naming_symbols.everything_else.applicable_kinds = *
-dotnet_naming_symbols.everything_else.applicable_accessibilities = *
+# Local functions are PascalCase
+dotnet_naming_rule.local_functions_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.local_functions_should_be_pascal_case.symbols = local_functions
+dotnet_naming_rule.local_functions_should_be_pascal_case.style = local_function_style
+
+dotnet_naming_symbols.local_functions.applicable_kinds = local_function
+
+dotnet_naming_style.local_function_style.capitalization = pascal_case
+
+# By default, name items with PascalCase
+dotnet_naming_rule.members_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.members_should_be_pascal_case.symbols = all_members
+dotnet_naming_rule.members_should_be_pascal_case.style = pascal_case_style
+
+dotnet_naming_symbols.all_members.applicable_kinds = *
+
+dotnet_naming_style.pascal_case_style.capitalization = pascal_case
+
+# CSharp code style settings:
+[*.cs]
+# Indentation preferences
+csharp_indent_block_contents = true
+csharp_indent_braces = false
+csharp_indent_case_contents = true
+csharp_indent_switch_labels = true
+csharp_indent_labels = flush_left
+
+# Prefer "var" everywhere
+csharp_style_var_for_built_in_types = true:suggestion
+csharp_style_var_when_type_is_apparent = true:suggestion
+csharp_style_var_elsewhere = true:suggestion
+
+# Prefer method-like constructs to have a block body
+csharp_style_expression_bodied_methods = false:none
+csharp_style_expression_bodied_constructors = false:none
+csharp_style_expression_bodied_operators = false:none
+
+# Prefer property-like constructs to have an expression-body
+csharp_style_expression_bodied_properties = true:none
+csharp_style_expression_bodied_indexers = true:none
+csharp_style_expression_bodied_accessors = true:none
+
+# Suggest more modern language features when available
+csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion
+csharp_style_pattern_matching_over_as_with_null_check = true:suggestion
+csharp_style_inlined_variable_declaration = true:suggestion
+csharp_style_throw_expression = true:suggestion
+csharp_style_conditional_delegate_call = true:suggestion
+
+# Newline settings
+csharp_new_line_before_open_brace = all
+csharp_new_line_before_else = true
+csharp_new_line_before_catch = true
+csharp_new_line_before_finally = true
+csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_members_in_anonymous_types = true

README.md

@@ -90,6 +90,7 @@ var ticket = await ticketClient.CreateTicketAsync(
 		Title = "Help me!",
 		GroupId = 1,
 		CustomerId = 1,
+		OwnerId = 1,
 	},
 	new TicketArticle
 	{

samples/Zammad.Connector/Commands/ExportTicketCommand.cs

@@ -80,8 +80,8 @@ private ExportTicketItem CreateTicketItem(Ticket ticket)
             {
                 Id = ticket.Id,
                 GroupId = ticket.GroupId,
-                PriorityId = ticket.PriorityId,
-                StateId = ticket.StateId,
+                PriorityId = ticket.PriorityId ?? 0,
+                StateId = ticket.StateId ?? 0,
                 OrganizationId = ticket.OrganizationId,
                 Number = ticket.Number,
                 Title = ticket.Title,

src/Zammad.Client/Core/ArgumentCheck.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 
@@ -25,4 +25,4 @@ internal static void ThrowIfNullOrEmpty<T>(IEnumerable<T> value, string paramNam
         }
 
     }
-}
+}

src/Zammad.Client/Core/Protocol/BasicHttpClientHandler.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Net.Http;
 using System.Net.Http.Headers;
 using System.Text;

src/Zammad.Client/Core/Protocol/HttpClientHandlerBase.cs

@@ -1,4 +1,4 @@
-using System.Net.Http;
+using System.Net.Http;
 using System.Threading;
 using System.Threading.Tasks;