Selective Barriers & Feedback Loops change #496
Draft
+38,443
−526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ca59c3f.
…s only Use SPIRV binaries & shaders in main Vulkan project instead of duplicating them
github-actions
bot
added
gpu
|
Download the artifacts for this pull request: |
This reverts commit ca59c3f.
…s only Use SPIRV binaries & shaders in main Vulkan project instead of duplicating them
…nto feature/vk/selective-barriers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selectively applies the Feedback loop detection and barriers commit based on whether or not the preferred GPU is an RDNA3 card.
This implementation is, frankly, fucking stupid.
It's literally just a duplicate of the Vulkan project.
The normal one is pre commit, RDNA3 one is post-commit.
The only thing that's done different depending on the GPU is which Vulkan implementation to initialize.
To test, ensure there's no visual regressions on RDNA3 cards.
And also see if the performance in Paper Mario: The Thousand Year Door and some of the Xenoblade games is fixed.