Map adding points #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/common-hosted-form-service into component-skeleton
fixed Unknown Component Render issue
Map submission Data Submission Updated
abhilash-aot
requested changes
Jun 28, 2024
app/frontend/package.json
Outdated
| @@ -31,6 +31,8 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@bcgov/bc-sans": "^1.0.1", | |||
| "@bcgov/smk": "^1.2.1", | |||
There was a problem hiding this comment.
Remove unused packages smk, smk/cli
app/frontend/public/index.html
Outdated
| @@ -1,5 +1,6 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <script src="../node_modules/@bcgov/smk/dist/smk.js"></script> | |||
There was a problem hiding this comment.
Remove as not using smk
components/package.json
Outdated
| @@ -47,8 +47,14 @@ | |||
| "components" | |||
| ], | |||
| "dependencies": { | |||
| "@bcgov/smk": "^1.2.1", | |||
There was a problem hiding this comment.
Update dependecies with used library
| } | ||
|
|
||
| attach(element) { | ||
| console.log('Attaching component to element'); |
There was a problem hiding this comment.
Remove the console logs from the codes
abhilash-aot
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added map component, added drawing functionality, submissions and point retrieval works.
Types of changes
New feature (non-breaking change which adds functionality)