Added fix for popup bug #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,10 +54,14 @@ class MapService { | |||
| map.on('draw:created', (e) => { | |||
| const layer = e.layer; | |||
| if (drawnItems.getLayers().length === options.numPoints) { | |||
| console.log('too many markers'); | |||
abhilash-aot
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once the submitter hit the limit of features (Marker, Circle, Polygon, etc..) added to the map, the user was not given any indication that they cannot add another feature. This enables a popup in the center of the map to notify the user that they have added all the features they can.
Types of changes
Checklist
Further comments