-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkcs12: initial types with decoders/encoders #1165
Merged
tarcieri
merged 31 commits into
RustCrypto:master
from
carl-wallace:pkcs12_encoder_decoder
Sep 8, 2023
Merged
pkcs12: initial types with decoders/encoders #1165
tarcieri
merged 31 commits into
RustCrypto:master
from
carl-wallace:pkcs12_encoder_decoder
Sep 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carl-wallace
commented
Jul 24, 2023
- Encoders and decoders only for PKCS 12 (decryption support and a builder will be submitted subsequently)
- Does not support sdsiCerts or alternative CRL types
- Copies the Pbkdf2Params and EncryptedPrivateKeyInfo definitions to avoid the lifetime requirement of the definitions in the pkcs5 crate
- Copies the Pbes2Params definition to avoid EncryptionScheme requirement of the definition in the pkcs5 crate
- Copies the PrivateKeyInfo definition to avoid the lifetime requirement of the definition in the pkcs8 crate
- SafeBag is a bit unusual owing to the OR'ed list of options (this will largely be hidden behind decryption and builder support)
…crypt support to use it. added a test case with a pfx from PKITS to exercise the kdf. added implementation of EncryptedPrivateKeyInfo.
… number of iterations. add a todo list.
…used, fmt, clippy
…enerated using openssl.
…key and cert with no mac that openssl can parse
…penssl can process.
…der features that are not present currently
16 tasks
@carl-wallace can you rebase? |
I can do that first thing tomorrow. |
tarcieri
reviewed
Sep 6, 2023
tarcieri
reviewed
Sep 6, 2023
tarcieri
reviewed
Sep 6, 2023
tarcieri
reviewed
Sep 6, 2023
tarcieri
changed the title
Pkcs12 encoders and decoders
pkcs12: initial types with decoders/encoders
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.