Skip to content

Commit

Permalink
Revert "powerpc/powernv/idle: Replace CPU feature check with PVR check"
Browse files Browse the repository at this point in the history
cpuidle stop state implementation has minor optimizations for P10
where hardware preserves more SPR registers compared to P9. The
current P9 driver works for P10, although does few extra
save-restores. P9 driver can provide the required power management
features like SMT thread folding and core level power savings on a P10
platform.

Until the P10 stop driver is available, revert the commit which allows
for only P9 systems to utilize cpuidle and blocks all idle stop states
for P10. CPU idle states are enabled and tested on the P10 platform
with this fix.

This reverts commit 8747bf3.

Fixes: 8747bf3 ("powerpc/powernv/idle: Replace CPU feature check with PVR check")
Signed-off-by: Pratik Rajesh Sampat <[email protected]>
Reviewed-by: Vaidyanathan Srinivasan <[email protected]>
Signed-off-by: Michael Ellerman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
pratiksampat authored and mpe committed Aug 27, 2020
1 parent 82715a0 commit 16d83a5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/powernv/idle.c
Original file line number Diff line number Diff line change
Expand Up @@ -1223,7 +1223,7 @@ static void __init pnv_probe_idle_states(void)
return;
}

if (pvr_version_is(PVR_POWER9))
if (cpu_has_feature(CPU_FTR_ARCH_300))
pnv_power9_idle_init();

for (i = 0; i < nr_pnv_idle_states; i++)
Expand Down

0 comments on commit 16d83a5

Please sign in to comment.