Add format data to vcf object #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better parsing of header This ensures that the text from nested headers is not split on commas that are enclosed in quotes. In particular, it ensures that this line ##INFO=<ID=DB,Number=0,Type=Flag,Description="dbSNP membership, build 129"> from the example in section 1.1 of the specs can be parsed. Note that section 1.2 lists the comma as one of the special characters which should always be 'represented with the capitalized percent encoding' when they are not used for their specific meaning. However, I assume this refers only to cases where they are not enclosed within quotes.
… returned from parse_vcf
This reverts commit d560aa4.
MrCurtis
force-pushed
the
add-format-data-to-vcf-object
branch
from
c18ad5c to
09b4e2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
formatattribute to the returnedVCFobject. The attribute allows access to all the metadata entries which satisfy part 1.4.4 of the specification.I imagine this isn't the best way to do things, either from an API or an implementation point of view, but hopefully it still moves things in the right direction.