Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor all attribute functions in rust-compile-base.cc #3336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saeitoshi-10
Copy link

@saeitoshi-10 saeitoshi-10 commented Dec 31, 2024

gcc/rust/ChangeLog:
* backend/rust-compile-base.cc (get_attributes):removed checker function (get_trait_name):removed checker function
* util/rust-attributes.cc (Attributes::get_attributes):added checker function (Attributes::get_trait_name): added checker function
* util/rust-attributes.h: added functions definitions in the header file for access

Thank you for making Rust GCC better!

If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.

Here is a checklist to help you with your PR.

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Addresses : #3291
*Please write a comment explaining your change. This is the message
that will be part of the merge commit.

	* backend/rust-compile-base.cc (get_attributes):removed checker function
	(get_trait_name):removed checker function
	* util/rust-attributes.cc (Attributes::get_attributes):added checker function
	(Attributes::get_trait_name): added checker function
	* util/rust-attributes.h: added functions definitions in the header file for access

Signed-off-by: Om Swaroop Nayak <[email protected]>
@powerboat9
Copy link
Contributor

Are you trying to use those functions elsewhere in the codebase?

@saeitoshi-10
Copy link
Author

no i didn't see any other implementations till but if it exists i'll be sure to replace that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants