-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 보관함 / 내가 그린 코스 수정, 삭제, 공유 기능 구현 #341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 노드 서버, 개발 서버는 DB 운영이 중단되어서 로그인부터 불가능
…into feature/feat-my-draw-course-share
- string resource id 뿐만 아니라 String 타입 인자도 받을 수 있도록 - 서버로부터 받은 문자열을 별도 리소스 없이 String으로 바로 지정하기 위해
- ui state 사용 - 도메인 레이어 dto 사용
- 상세페이지 들어갔다 나올 때마다 서버 통신을 진행하는 게 비효율적이므로
unam98
reviewed
Mar 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~! 하은이 최고얌
카톡으로 영상 보냈는데 아래와 같은 버그가 있습니다.
- 로그인한 상태에서 내가 카톡으로 공유한 링크 터치하고 들어오면 내가 그린 코스 상세페이지가 아닌 보관함으로 이동
- 링크를 통해 내가 그린 코스 상세페이지로 들어와서 "시작하기" 누르면 지도에 코스 마커가 싹 날아가서 아무것도 안 보이는 문제
app/src/main/java/com/runnect/runnect/util/custom/toolbar/ToolbarMenu.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/runnect/runnect/presentation/scheme/SchemeActivity.kt
Show resolved
Hide resolved
app/src/main/java/com/runnect/runnect/presentation/scheme/SchemeActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/runnect/runnect/presentation/scheme/SchemeActivity.kt
Outdated
Show resolved
Hide resolved
dongx0915
reviewed
Mar 24, 2024
app/src/main/java/com/runnect/runnect/domain/entity/MyDrawCourse.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/runnect/runnect/data/dto/request/RequestPatchMyDrawCourseTitle.kt
Show resolved
Hide resolved
app/src/main/java/com/runnect/runnect/presentation/countdown/CountDownActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/runnect/runnect/util/custom/toolbar/ToolbarMenu.kt
Outdated
Show resolved
Hide resolved
…into feature/feat-my-draw-course-share-edit
…into feature/feat-my-draw-course-share-edit
leeeha
changed the title
[feat] 보관함 / 내가 그린 코스 수정, 삭제, 공유 기능 구현
[FEAT] 보관함 / 내가 그린 코스 수정, 삭제, 공유 기능 구현
Mar 29, 2024
dongx0915
approved these changes
Apr 13, 2024
…into feature/feat-my-draw-course-share-edit
unam98
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
✨ 작업 내용
✨ PR 포인트
다른 사람이 공유한 코스 링크를 조회할 때 현재 배포 서버에서는 응답값 처리 관련 오류가 발생합니다!
따라서 배포 서버에 반영되기 전까지는 "테스트 서버"에서 확인 부탁드립니다!
CommonToolbarLayout에서 Text 메뉴 추가할 때, 기존 코드로는 resourceId만 인자로 넣을 수 있었는데
현재 화면에서는 서버의 응답값, 사용자 입력에 따라 툴바 제목이 바뀌어야 하므로
Text 데이터 클래스의 속성에 String 타입도 추가했습니다!
📸 스크린샷/동영상