Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] 마이페이지 / 러닝 기록 api responseDTO 수정 #328

Merged
merged 1 commit into from
Feb 16, 2024
Merged

[FIX] 마이페이지 / 러닝 기록 api responseDTO 수정 #328

merged 1 commit into from
Feb 16, 2024

Conversation

unam98
Copy link
Contributor

@unam98 unam98 commented Feb 15, 2024

📌 개요

서버 Spring으로 마이그레이션하면서 responseDTO 바뀐 게 있는데 반영이 안 돼있었습니다.
id -> userId

✨ 작업 내용

  • 러닝 기록 api responseDTO 수정

✨ PR 포인트

  • 이전 작업자가 responseDTO 만든 방식은 명세에 적혀있는 sample response랑 비교하기 어려운 것 같습니다. 당장 수정하기에는 사이드이펙트가 터질 것 같아서 @SerialName을 달아서 직렬화가 정상적으로 이루어질 수 있게 맵핑만 해주었습니다.

📸 스크린샷/동영상

@unam98 unam98 self-assigned this Feb 15, 2024
@unam98 unam98 added 우남 🐼 우남 담당 FIX 💥 버그 및 오류 해결 labels Feb 15, 2024
sxunea
sxunea approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@sxunea sxunea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실행해봤는데 잘 되네요 수고하셨습니다 ~!

leeeha
leeeha approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@leeeha leeeha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 완료!

@unam98 unam98 merged commit 7a295f9 into develop Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxunea sxunea sxunea approved these changes

@leeeha leeeha leeeha approved these changes

@dongx0915 dongx0915 Awaiting requested review from dongx0915

Assignees

@unam98 unam98

Labels
FIX 💥 버그 및 오류 해결 우남 🐼 우남 담당
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] 러닝 기록 responseDTO 수정
3 participants
@unam98 @leeeha @sxunea