[FEAT] 코스 상세 페이지 / Firebase 동적 링크로 코스 공유 구현 #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeha
approved these changes
Feb 16, 2024
| } | ||
| .addOnFailureListener(this) { e -> | ||
| Timber.e("getDynamicLink:onFailure", e) | ||
| completion(false) |
There was a problem hiding this comment.
고차함수를 이렇게 활용할 수 있군요! 가독성 향상된 거 같아서 좋습니다!
| @@ -238,9 +242,42 @@ class CourseDetailActivity : | |||
| } | |||
| } | |||
|
|
|||
| private fun sendFirebaseDynamicLink(title: String, desc: String, image: String) { | |||
| val link = "https://rnnt.page.link/?courseId=$publicCourseId" | |||
There was a problem hiding this comment.
문자열 리소스 사용하거나 companion 객체 안에 상수화 시켜주는 게 좋을 거 같습니다! (오타 발생 가능성)
|
|
||
| FirebaseDynamicLinks.getInstance().createDynamicLink() | ||
| .setLink(Uri.parse(link)) | ||
| .setDomainUriPrefix("https://rnnt.page.link") |
|
|
||
| private fun shareLink(url: String) { | ||
| val intent = Intent(Intent.ACTION_SEND).apply { | ||
| type = "text/plain" |
|
추후 별도 브랜치에서 피드백 반영 예정 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
✨ 작업 내용
✨ PR 포인트
📸 스크린샷/동영상
KakaoTalk_20240215_212115559.mp4