[FIX] 마이페이지-러닝 기록 / 이미지뷰 elevation 제거 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- strokeColor, strokeWidth 활용을 위해 MaterialCardView로 변경해주었음
leeeha
approved these changes
Sep 23, 2023
| app:layout_constraintDimensionRatio="1:1" | ||
| app:layout_constraintStart_toStartOf="@id/iv_my_page_history_frame" | ||
| app:layout_constraintTop_toTopOf="@id/iv_my_page_history_frame"> | ||
| app:layout_constraintTop_toTopOf="@id/iv_my_page_history_frame" | ||
| app:strokeColor="#D9D9D9" |
There was a problem hiding this comment.
colors.xml 파일에 컬러 리소스를 따로 만들어서 사용하면 더 좋을 거 같습니다! 다른 곳에서 재사용 하기도 편하고 오타도 방지할 수 있을 거 같아서요 :)
leeeha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 개요
closed #237 마이페이지-러닝기록 / 이미지뷰 elevation 제거
✨ 작업 내용
✨ PR 포인트
모서리 둥글게 imageView의 frame을 만들고 이 안에 서버에서 받아온 image data를 바인딩할 때 cardView 말고 더 간편한 방법이 있을까요?!
📸 스크린샷/동영상