Update AgentTicketPhone.tt #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed second appearance of Dynamic Field RenderBlock, which caused Dynamic Fields to appear twice.
|
Note to self: check whether this also affects rel-10_1. |
|
It seems like some commits from rel-10_1 did not make it to master. The codebase seems quite different. For example, my commit: 17ee9b2 or @jacasavilcap last commit: 115e673 I can offer to make a new PR for my part if wished. It removes AgentTicketPhone.tt and AgentTicketEmail.tt as they have nothing to do with this package. |
|
Yes, there are a lot of things we have to go over, currently, e.g. placing the CIP-matrix calculation in the itsmcore, to make the ServiceCatalog and the InciProblemManagement work together, etc.. Currently the ServiceCatalog is in a quite chaotic state. We will go over all of this, and also merge your changes of course, after discussing this in two weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed second appearance of Dynamic Field RenderBlock, which caused Dynamic Fields to appear twice.
Concerning Issue #2