SporeModManager: use std::vector<char>().reserve() in Zip.cpp

Rosalie241 · Nov 21, 2023 · aae742e · aae742e
1 parent 2f7463b
commit aae742e
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/SporeModManager/SporeModManagerHelpers/Zip.cpp b/SporeModManager/SporeModManagerHelpers/Zip.cpp
@@ -28,7 +28,7 @@ using namespace SporeModManagerHelpers;
 //
 
 static std::map<std::filesystem::path, std::ifstream> l_ZipFileStreams;
-static std::vector<char>                              l_ZipFileBuffer(UNZIP_READ_SIZE);
+static std::vector<char>                              l_ZipFileBuffer;
 
 //
 // Local Functions
@@ -137,6 +137,9 @@ bool Zip::ExtractFile(ZipFile zipFile, std::filesystem::path file, std::filesyst
     int bytesRead = 0;
     std::ofstream outputFileStream;
 
+    // ensure the global buffer has the size reserved
+    l_ZipFileBuffer.reserve(UNZIP_READ_SIZE);
+
     // try to find file in zip
     if (unzLocateFile(zipFile, file.string().c_str(), 2) != UNZ_OK)
     {
@@ -182,6 +185,9 @@ bool Zip::ExtractFile(ZipFile zipFile, std::filesystem::path file, std::vector<c
 {
     int bytesRead = 0;
 
+    // ensure the global buffer has the size reserved
+    l_ZipFileBuffer.reserve(UNZIP_READ_SIZE);
+
     // try to find file in zip
     if (unzLocateFile(zipFile, file.string().c_str(), 2) != UNZ_OK)
     {