[IMPROVE] Updating [email protected] to [email protected] #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the package uses [email protected]. The issue is that the /token endpoint returns
token_typeasbearer. Though it is valid, a lot of apps/services support onlyBearer. This change has been made in 3.x.x versions. I encountered this issue while adding RocketChat oauth2 login in RC4Community.I have replaced [email protected] with express-oauth-server. It uses [email protected]. I have made the necessary changes for the migrations. See https://oauth2-server.readthedocs.io/en/latest/misc/migrating-v2-to-v3.html.
No additional changes are required in the RocketChat core repo.
I have published a meteor package abhinavkrin:oauth2-server if you want to try the changes.