forked from sampaiodiego/rocket.chat.app-poll
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Live poll: Multi-Question and Timed-Polls #13
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a72cb8e
[NEW] Creates LivePoll modal
RonLek 3c5995e
[NEW] Modifies IPoll interface for live polls
RonLek 92e2c0e
[NEW] Adds Next Poll button for live polls
RonLek 8b45888
[NEW] Creates live slash subcommand
RonLek 08cb838
[NEW] Live poll message integration
RonLek 3fda479
[NEW] Updates Apps-Engine version and adds scheduler permission
RonLek 519373b
[NEW] Adds livePollEndTime property to Poll interface
RonLek 5705456
[NEW] Adds time to vote field within poll modal
RonLek 5d60234
[NEW] Adds poll will end block to live poll message
RonLek db58e8f
[NEW] Integrates scheduler to trigger next poll on ttv end
RonLek a34ff7a
Merge branch 'master' into live-poll
RonLek a9afe27
Merge branch 'master' into live-poll
RonLek 4c5edae
[NEW] Adds ability to late retrieve live polls
RonLek cf9aa3f
[IMPROVE] Adds app permissions
RonLek 5b5d179
[IMPROVE] Adds live poll param examples
RonLek 6d74d4d
[NEW] Adds timezone for poll finish time
RonLek 7b50dc6
[FIX] Lint errors
RonLek 22740e1
[FIX] Live poll early force finish bug
RonLek df03b72
[FIX] Load poll across multiple rooms
RonLek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,8 @@ | ||
{ | ||
"cmd_description": "Create a simple poll", | ||
"params_example": "Type your question or fill it up on the form." | ||
"cmd_description": "Create a simple poll or a Live Poll", | ||
"params_example": "Type your question or fill it up on the form. Optionally follow with live <number> or live save <number> or live load <id>.", | ||
"use_user_name_label": "Use name attribute to display voters, instead of username", | ||
"use_user_name_description": "When checked, display voters as full user names instead of username", | ||
"timezone_label": "TimeZone", | ||
"timezone_description": "Timezone to display Poll finish time in" | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This app uses a lot of other permissions like
slashcommand
,message.read
etc which we need to also declare over here. For a list of all permissions, please refer here and declare ONLY the permissions being used by this app.PS: Earlier since this app was using apps-engine version < 1.20.0 which is when the permission system was introduced, we didn't have to explicitly declare any such permissions as the apps-engine assigns such apps
default permission
. However now, since our app is going to be using schedular apis which is on 1.23.0 version of apps-engine - we now need to declare all these permissions explicitly and if this isn't done, the app will start throwing permission errorsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the permissions. Please let me know if I missed any. Thanks.