Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CookieManager domain value handled port case #5874

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hcoz
Copy link

@hcoz hcoz commented Sep 21, 2024

Proposed changes

Jitsi meeting view won't open if the server url has a port value because CookieManager throws a "domain and server url don't match" error. This is fixed by removing the port value from the domain if it exists. Also moved the setCookie method to useEffect as suggested by react.

Issue(s)

#5852

How to test or reproduce

Try joining a jitsi meeting in a workspace that has a server url with a port like www.my-workspace.com:8080.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


EXT02D057618 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@diegolmello
Copy link
Member

@hcoz Do you have a Jitsi server we can use to test?
Otherwise it may take a while for us to review this PR, since we're not used to running local Jitsi servers.

@hcoz
Copy link
Author

hcoz commented Sep 24, 2024

Hi @diegolmello,
Unfortunately, I cannot provide it for testing as I am working on my client's server.

@DustpaN-Spb
Copy link

Please review 🙏

@diegolmello
Copy link
Member

@DustpaN-Spb can't review without a test server.
We can create one, but it's going to take a while, since it's a low priority.
If we had a server, we could do it right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants