Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[WIP][NEW] Group same user messages #2299

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

Adizbek
Copy link
Contributor

@Adizbek Adizbek commented May 5, 2019

@RocketChat/android

Closes #712
As describe in issue:

Group messages:

Take in consideration the setting (Message_GroupingPeriod -> default is 900 seconds);
When there's a day separator, can't be sequential;
When a message is a system message (message removed, pinned message, permission changes, etc)
Users need to be the same in order to group it;

Some criteria not implemented yet.

Screenshots or GIF for the change:

https://youtu.be/3ciV8ZmTaE0

@Adizbek
Copy link
Contributor Author

Adizbek commented May 14, 2019

@filipedelimabrito I have fixed all issues which you listed above.

@jungeonkim
Copy link

Is not it good to consider it when the alias is different?

RocketChat/Rocket.Chat.iOS#2684

@Adizbek
Copy link
Contributor Author

Adizbek commented May 14, 2019

@jungeonkim Yes, you're right. I have fixed. Now code looks better.

@philipbrito
Copy link
Contributor

@Adizbek Is it still a WIP?

@Adizbek
Copy link
Contributor Author

Adizbek commented May 14, 2019

@filipedelimabrito The only last part remained, As said in issue #712

Message_GroupingPeriod -> default is 900 seconds

I couldn't find how to realize it, currently it is manually set to 900sec.

@peterkogit
Copy link

Something all stopped

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW] Group same user messages
4 participants