Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve radar clustering with variable separation on distance ranges (still CPU only) #260

Merged
merged 11 commits into from
Mar 7, 2024

Conversation

msz-rai
Copy link
Collaborator

@msz-rai msz-rai commented Mar 5, 2024

No description provided.

@msz-rai msz-rai force-pushed the feature/improve-radar-clustering branch from 79e4e8c to 9753aa7 Compare March 5, 2024 11:07
Copy link
Collaborator

@prybicki prybicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overally LGTM, but please address comments.

include/rgl/api/core.h Outdated Show resolved Hide resolved
include/rgl/api/core.h Outdated Show resolved Hide resolved
include/rgl/api/core.h Outdated Show resolved Hide resolved
include/rgl/api/core.h Outdated Show resolved Hide resolved
include/rgl/api/core.h Outdated Show resolved Hide resolved
include/rgl/api/core.h Outdated Show resolved Hide resolved
src/repr.hpp Outdated Show resolved Hide resolved
src/graph/RadarPostprocessPointsNode.cpp Outdated Show resolved Hide resolved
src/graph/RadarPostprocessPointsNode.cpp Outdated Show resolved Hide resolved
src/graph/RadarPostprocessPointsNode.cpp Outdated Show resolved Hide resolved
include/rgl/api/core.h Outdated Show resolved Hide resolved
include/rgl/api/core.h Outdated Show resolved Hide resolved
src/graph/NodesCore.hpp Outdated Show resolved Hide resolved
src/graph/NodesCore.hpp Outdated Show resolved Hide resolved
src/graph/RadarPostprocessPointsNode.cpp Outdated Show resolved Hide resolved
src/graph/RadarPostprocessPointsNode.cpp Outdated Show resolved Hide resolved
@msz-rai msz-rai force-pushed the feature/improve-radar-clustering branch from d18a452 to a663c3b Compare March 6, 2024 13:29
src/graph/RadarPostprocessPointsNode.cpp Outdated Show resolved Hide resolved
src/graph/RadarPostprocessPointsNode.cpp Outdated Show resolved Hide resolved
src/graph/RadarPostprocessPointsNode.cpp Outdated Show resolved Hide resolved
src/graph/RadarPostprocessPointsNode.cpp Outdated Show resolved Hide resolved
@msz-rai msz-rai merged commit ce7ceae into develop Mar 7, 2024
20 checks passed
@msz-rai msz-rai deleted the feature/improve-radar-clustering branch March 7, 2024 11:52
msz-rai added a commit that referenced this pull request Jun 11, 2024
…(still CPU only) (#260)

* Add ranged separation for distance and radial speed

* Add missing static_asset for structs

* Introduce rgl_radar_separations_t

* Follow math convention (a < b < c)

Co-authored-by: Piotr Rybicki <[email protected]>

* Review changes

* Add validation to the radarScopes

* Fix clusters merging check

* Fix iteration and required field list

* Add clustering test

* Add more test cases

* Review changes

---------

Co-authored-by: Piotr Rybicki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants