-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve radar clustering with variable separation on distance ranges (still CPU only) #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msz-rai
force-pushed
the
feature/improve-radar-clustering
branch
from
March 5, 2024 11:07
79e4e8c
to
9753aa7
Compare
prybicki
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overally LGTM, but please address comments.
Co-authored-by: Piotr Rybicki <[email protected]>
msz-rai
force-pushed
the
feature/improve-radar-clustering
branch
from
March 6, 2024 13:29
d18a452
to
a663c3b
Compare
prybicki
approved these changes
Mar 7, 2024
msz-rai
added a commit
that referenced
this pull request
Jun 11, 2024
…(still CPU only) (#260) * Add ranged separation for distance and radial speed * Add missing static_asset for structs * Introduce rgl_radar_separations_t * Follow math convention (a < b < c) Co-authored-by: Piotr Rybicki <[email protected]> * Review changes * Add validation to the radarScopes * Fix clusters merging check * Fix iteration and required field list * Add clustering test * Add more test cases * Review changes --------- Co-authored-by: Piotr Rybicki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.