[build] Remove two constants from python's version.bzl #22357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: medium
status: single reviewer ok
These constants unnecessarily couple our BUILD files to our repository rule, without the py_toolchain as an intermediary. Our goal is to use the toolchain to fully encapsulate the selected python interpreter. (1) PYTHON_EXTENSION_SUFFIX Simplify how pydrake module shared libraries are named in our binary packages. The importlib.machinery package defines many possible values for valid EXTENSION_SUFFIXES (i.e., the filename extension used for native code), e.g., on Ubuntu 22.04 the possible values are ['.cpython-310-x86_64-linux-gnu.so', '.abi3.so', '.so']. Previously we used the first choice (with the python version baked in) but this is awkward, so now we use the last option (plain '.so'). The distinction would only matter if we packaged builds for multiple python versions into the same release artifact at once, which we never do. The first choice would also have become moot after we switch to using ABI 3 in the future (in which case we'll use the middle choice). Ditto for lcm-python's shared library. (2) PYTHON_SITE_PACKAGES This is no longer provided as an opaque constant; its correct value is trivially derivable from the Python version number so we'll just use the longhand anywhere we need such a path. While we're anyway cleaning up the repository.bzl, we also inline the "interpreter_attrs" dictionary because its name was a lie and keeping it out-of-line doesn't gain us anything anyway.
jwnimmer-tri
force-pushed
the
repo-python-no-site-no-ext
branch
from
1d493b2 to
fd852bd
Compare
|
+@rpoyner-tri for both reviews, please. |
rpoyner-tri
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #22346 and #20731.
This change is