[build] Disable autoloaded (built-in) bazel rules #22305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
status: single reviewer ok
jwnimmer-tri
force-pushed
the
bzlmod-no-autoload
branch
from
dedbe13 to
5552f38
Compare
jwnimmer-tri
force-pushed
the
bzlmod-no-autoload
branch
2 times, most recently
from
4762d59 to
8326231
Compare
|
FYI @ggould-tri @rpoyner-tri @xuchenhan-tri this is ready for reviews now, if anyone wants to sign up. |
rpoyner-tri
reviewed
Dec 13, 2024
There was a problem hiding this comment.
+@rpoyner-tri for reviews.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform)
rpoyner-tri
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Reviewed 29 of 29 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform)
tools/skylark/cc.bzl line 5 at r1 (raw file):
For all code built by Drake (both first-party code, and built-from-source externals), we should be using this file's macros. We should never call `native.cc_foo()` from anywhere other than this file, and any BUILD file
nit Does this comment need updating, now that we are avoiding native rules for c++ altogether?
rpoyner-tri
reviewed
Dec 13, 2024
jwnimmer-tri
force-pushed
the
bzlmod-no-autoload
branch
from
8326231 to
dd1517b
Compare
The release-notable changes here are the addition of rules_java and rules_shell as new dependencies and the bump of the minimum supported bazel version up to 7.4. As part of uniform loading of rules we also refactor to provide a single point of control for shell and java, like we had previously done for cc and python and tidy up some missing pieces.
jwnimmer-tri
force-pushed
the
bzlmod-no-autoload
branch
from
dd1517b to
0f5f74b
Compare
RussTedrake
pushed a commit
to RussTedrake/drake
that referenced
this pull request
Dec 15, 2024
) The release-notable changes here are the addition of rules_java and rules_shell as new dependencies and the bump of the minimum supported bazel version up to 7.4. As part of uniform loading of rules we also refactor to provide a single point of control for shell and java, like we had previously done for cc and python and tidy up some missing pieces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #20731.
The autoloading behavior will become deprecated and eventually go away in future bazel versions. This gets out ahead of the problem by opting-out of the autoloading. Note that the opt-out in
bazel.rcis not inherited by downstream projects; it is only for Drake.Loading the specific rules versions also helps make it crystal clear to us which versions of starlark rules we are running. We definitely do not want to be mixing and matching versions in different places. With autoloading turned off, we know for sure what we're running, based on either the MODULE or WORKSPACE file (depending on which mode we're using).
This change is