-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[solvers] IpoptSolver doesn't hard-code the linear solver #22275
[solvers] IpoptSolver doesn't hard-code the linear solver #22275
Conversation
+@rpoyner-tri for (low priority) feature review, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers
solvers/ipopt_solver.cc
line 157 at r1 (raw file):
const std::vector<std::string_view> linear_solvers = internal::GetSupportedIpoptLinearSolvers(); if (!linear_solvers.empty()) {
nit is empty string a legal value for default_linear_solver_ ? If so, cool. If not, shouldn't there be an else
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs at least two assigned reviewers
solvers/ipopt_solver.cc
line 157 at r1 (raw file):
Previously, rpoyner-tri (Rick Poyner (rico)) wrote…
nit is empty string a legal value for default_linear_solver_ ? If so, cool. If not, shouldn't there be an
else
?
Yes, empty is a legal value. When empty, these lines earlier in this file ...
if (!default_linear_solver.empty()) {
set_string_option("linear_solver", default_linear_solver);
}
... will not try to set any Drake-specific default, instead allowing IPOPT's built-in upstream default to remain unchanged.
This could happen if the user is building Drake as a Bazel external and has replaced our build of @ipopt
with their own customized build.
+@SeanCurtis-TRI for platform review per schedule, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),SeanCurtis-TRI(platform)
Towards #21476. This will simplify the work of changing which linear solver(s) the build system provides.
This change is