[tools] Disable cpplint's build/include checks #22264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
release notes: none
|
+@rpoyner-tri and +@sherm1 for reviews, please. FYI @sammy-tri @ggould-tri @xuchenhan-tri @SeanCurtis-TRI in case you would like to weigh in. |
sherm1
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform)
rpoyner-tri
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sherm1(platform)
rpoyner-tri
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #20731.
When using
--enable_bzlmod=true, the default runfiles layout is not compatible with howcpplintexpects things to work. (In particular, the root of our runfiles is named_maininstead ofdrakenow.) With some major surgery to our skylark lint rules we could probably get it working, but I don't think this feature is important enough to merit that level of surgery and maintenance. We haveclang-format-includeswhich ensures the self-include statement is always first atop the file, and that seems good enough; forgetting the self-include entirely is not a common failure.This change is