[manipulation] Purge some obsolete tools #21398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The meshlab inertia thing is obsolete now that we have mesh_to_model. The convert_to_visualize_collisions is obsolete now that we have proximity visualization available by default. Add a purge reminder to the show_model shim. The important outcome here is that we can delete some __init__ files, which cause path-confusion trouble for bzlmod.
jwnimmer-tri
added
priority: low
status: single reviewer ok
|
+@rpoyner-tri for both reviews, please. |
rpoyner-tri
reviewed
May 6, 2024
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform)
RussTedrake
pushed a commit
to RussTedrake/drake
that referenced
this pull request
Dec 15, 2024
The meshlab inertia thing is obsolete now that we have mesh_to_model. The convert_to_visualize_collisions is obsolete now that we have proximity visualization available by default. Add a purge reminder to the show_model shim. The important outcome here is that we can delete some __init__ files, which cause path-confusion trouble for bzlmod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meshlab inertia thing is obsolete now that we have mesh_to_model.
The convert_to_visualize_collisions is obsolete now that we have proximity visualization available by default.
Add a purge reminder to the show_model shim.
The important outcome here is that we can delete some
__init__files, which cause path-confusion trouble for bzlmod (towards #20731).This change is