[lcm] Remove deprecated code 2024-01 #20716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
release notes: removal of deprecated
jwnimmer-tri
force-pushed
the
deprecation-2024-01-lcm
branch
2 times, most recently
from
51a68c1 to
3f87b63
Compare
jwnimmer-tri
changed the title
jwnimmer-tri
removed
the
status: single reviewer ok
Remove deprecated access to underlying native LCM C++ object. Adjust DrakeLcmLog implementation to avoid calling LCM's C++ code. The C++ code is not ABI-stable. (This was missed in d34b2dc.)
jwnimmer-tri
force-pushed
the
deprecation-2024-01-lcm
branch
from
3f87b63 to
8c78a64
Compare
|
+@ggould-tri for feature review, please. (Follow-up from #20116.) |
ggould-tri
reviewed
Jan 2, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: needs at least two assigned reviewers
|
+@rpoyner-tri for platform review per schedule, please. |
rpoyner-tri
reviewed
Jan 2, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),ggould-tri(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated access to underlying native LCM C++ object.
Adjust DrakeLcmLog implementation to avoid calling LCM's C++ code. The C++ code is not ABI-stable. (This was missed in #20116.)
This change is