Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Bump VGT to support hidden visibility #20387

Conversation

calderpg-tri
Copy link
Contributor

@calderpg-tri calderpg-tri commented Oct 18, 2023

Equivalent to #19893 for VGT, towards #17231

+@jwnimmer-tri for review, thanks!


This change is Reviewable

Copy link
Contributor Author

@calderpg-tri calderpg-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @calderpg-tri)


tools/workspace/voxelized_geometry_tools/repository.bzl line 8 at r1 (raw file):

    github_archive(
        name = name,
        repository = "calderpg/voxelized_geometry_tools",

working Return to TRI mirror once VGT#49 lands

Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will await the final git sha pin before I emojiate here.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, missing label for release notes (waiting on @calderpg-tri)

Copy link
Contributor Author

@calderpg-tri calderpg-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @calderpg-tri)


tools/workspace/voxelized_geometry_tools/repository.bzl line 8 at r1 (raw file):

Previously, calderpg-tri wrote…

working Return to TRI mirror once VGT#49 lands

Done.

@jwnimmer-tri jwnimmer-tri added release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html labels Oct 18, 2023
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: +(status: single reviewer ok) +(release notes: fix)

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @calderpg-tri)

@calderpg-tri calderpg-tri added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label Oct 18, 2023
@calderpg-tri calderpg-tri merged commit 6035a45 into RobotLocomotion:master Oct 18, 2023
1 check passed
@calderpg-tri calderpg-tri deleted the bump_vgt_namespace_annotations branch October 18, 2023 04:18
WawasCode pushed a commit to WawasCode/drake that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants