Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Use hidden symbols for tinyobjloader #20357

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Oct 12, 2023

Towards #17231.

+@SeanCurtis-TRI for both reviews, please.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: fix This pull request contains fixes (no new features) labels Oct 12, 2023
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM: X2

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)

@SeanCurtis-TRI SeanCurtis-TRI merged commit 905fc39 into RobotLocomotion:master Oct 12, 2023
1 check passed
@jwnimmer-tri jwnimmer-tri deleted the vendor-tinyobj branch October 12, 2023 13:47
WawasCode pushed a commit to WawasCode/drake that referenced this pull request Oct 31, 2023
WawasCode pushed a commit to WawasCode/drake that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants