[lcm] Hotfix for "Eschew LCM C++ API" #20137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: high
status: single reviewer ok
Previously, when multicast was disabled all operations printed a warning to the console and then did nothing. The prior commit changed that to throw an error instead, which was breaking. Instead, let LCM still print the console warning but then instead of throwing provide an inert DrakeLcm instead.
jwnimmer-tri
force-pushed
the
lcm-c-abi-hotfix
branch
from
870cbb1 to
bb4b61f
Compare
|
We still need someone to review the details, but I've confirmed that this resolves the failures I reported in #20116. |
There was a problem hiding this comment.
+@xuchenhan-tri
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee xuchenhan-tri(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when multicast was disabled all operations printed a warning to the console and then did nothing. The prior commit changed that to throw an error instead, which was breaking.
Instead, let LCM still print the console warning but then instead of throwing provide an inert DrakeLcm instead.
Closes #20136.
Amends #20116.
This change is