[tools] Add cmake_configure_files (plural) macro #19952
Conversation
jwnimmer-tri
added
priority: medium
status: single reviewer ok
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions
tools/workspace/cmake_configure_file.bzl line 101 at r1 (raw file):
) def cmake_configure_files(
BTW, can you refer me to a place where this new function is used?
Code quote:
def cmake_configure_files(tools/workspace/cmake_configure_file.py line 163 at r1 (raw file):
and len(args.input) > 0): parser.print_usage() sys.exit(1)
nit, is there a useful error message if len(args.input) == 0?
Code quote:
sys.exit(1)
This is important when configuring multiple files with the same bag of definitions, so `strict = True` mode still makes sense. Improve the diagnostic output to show *all* missing definitions, not just the first one. This helps a lot during Local development.
jwnimmer-tri
force-pushed
the
configure-files-plural
branch
from
b24fdda to
dfe40d8
Compare
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion
tools/workspace/cmake_configure_file.bzl line 101 at r1 (raw file):
Previously, xuchenhan-tri wrote…
BTW, can you refer me to a place where this new function is used?
It's used in #19945.
tools/workspace/cmake_configure_file.py line 163 at r1 (raw file):
Previously, xuchenhan-tri wrote…
nit, is there a useful error message if
len(args.input) == 0?
Now there is.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee xuchenhan-tri(platform)
Towards #19945.
+@xuchenhan-tri for both reviews (off-schedule), please.
This change is