Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Externals February 2023 #18753

Merged
merged 10 commits into from
Feb 8, 2023
Merged

Upgrade Externals February 2023 #18753

merged 10 commits into from
Feb 8, 2023

Conversation

mwoehlke-kitware
Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware commented Feb 8, 2023 •
edited by sherm1
Loading

Toward #18734.

This change is Reviewable

@mwoehlke-kitware mwoehlke-kitware added status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits release notes: fix This pull request contains fixes (no new features) labels Feb 8, 2023
@mwoehlke-kitware mwoehlke-kitware mentioned this pull request Feb 8, 2023
Closed
2 tasks
@mwoehlke-kitware
Copy link
Contributor Author

@drake-jenkins-bot mac-x86-monterey-clang-bazel-experimental-release please

@mwoehlke-kitware mwoehlke-kitware added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Feb 8, 2023
@mwoehlke-kitware
Copy link
Contributor Author

+@xuchenhan-tri for review please.

@jwnimmer-tri, FYI, this would be a good opportunity to comment on the commit message generated by the updated new_release (#18673). See the mypy commit, particularly.

BetsyMcPhail
BetsyMcPhail reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee xuchenhan-tri(platform), when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @xuchenhan-tri)

xuchenhan-tri
xuchenhan-tri reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@xuchenhan-tri xuchenhan-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @mwoehlke-kitware)

@jwnimmer-tri jwnimmer-tri merged commit 54d0429 into RobotLocomotion:master Feb 8, 2023
@mwoehlke-kitware mwoehlke-kitware deleted the upgrades branch February 8, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuchenhan-tri xuchenhan-tri xuchenhan-tri left review comments

@BetsyMcPhail BetsyMcPhail BetsyMcPhail left review comments

Assignees

@xuchenhan-tri xuchenhan-tri

Labels
release notes: fix This pull request contains fixes (no new features) status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mwoehlke-kitware @BetsyMcPhail @xuchenhan-tri @jwnimmer-tri