[workspace] Remove deprecated @json and @nlopt externals #18532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
status: single reviewer ok
|
+@sherm1 for both reviews per schedule, please. |
sherm1
reviewed
Jan 4, 2023
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee sherm1(platform) (waiting on @jwnimmer-tri)
xuchenhan-tri
pushed a commit
to xuchenhan-tri/drake
that referenced
this pull request
Feb 3, 2023
xuchenhan-tri
pushed a commit
to xuchenhan-tri/drake
that referenced
this pull request
Feb 6, 2023
marcoag
pushed a commit
to marcoag/drake
that referenced
this pull request
Mar 8, 2023
This was referenced May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were supposed to disappear 2022-09 but there was a typo in the comment.
Follow-up from #17283 and #17288.
This change is