[common] Switch to std::filesystem #17834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
release notes: newly deprecated
|
@drake-jenkins-bot mac-big-sur-clang-bazel-experimental-release please |
46 tasks
jwnimmer-tri
force-pushed
the
filesystem
branch
from
08002b4 to
3eab23d
Compare
Deprecate unused ghc_filesystem external.
jwnimmer-tri
force-pushed
the
filesystem
branch
from
3eab23d to
a1e49fa
Compare
jwnimmer-tri
added
the
status: single reviewer ok
|
+@rpoyner-tri for both reviews or delegation per schedule, please. |
rpoyner-tri
reviewed
Sep 6, 2022
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform) (waiting on @jwnimmer-tri)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate unused
@ghc_filesystemexternal.Towards #17231.
This change is