[workspace] Build tinyxml2 from source #17830
Conversation
jwnimmer-tri
added
priority: low
release notes: newly deprecated
|
@drake-jenkins-bot mac-big-sur-clang-bazel-experimental-release please |
Deprecate the repository rule for the OS library.
jwnimmer-tri
force-pushed
the
workspace-tinyxml-internal
branch
from
335799d to
9585b5e
Compare
|
+@rpoyner-tri for feature review, please. |
There was a problem hiding this comment.
Reviewed 22 of 24 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: needs at least two assigned reviewers (waiting on @jwnimmer-tri)
|
+@xuchenhan-tri for platform review tomorrow, please. |
There was a problem hiding this comment.
platform 
Reviewed 22 of 24 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)
tools/workspace/default.bzl line 355 at r2 (raw file):
if "tinyobjloader" not in excludes: tinyobjloader_repository(name = "tinyobjloader", mirrors = mirrors) if "tinyxml2" not in excludes:
question: do we still need this?
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion (waiting on @xuchenhan-tri)
tools/workspace/default.bzl line 355 at r2 (raw file):
Previously, xuchenhan-tri wrote…
question: do we still need this?
Yes, per the Stable API section about default.bzl "... we will deprecate it prior to removing our definition of the dependency".
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),xuchenhan-tri(platform) (waiting on @jwnimmer-tri)
tools/workspace/default.bzl line 355 at r2 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
Yes, per the Stable API section about
default.bzl"... we will deprecate it prior to removing our definition of the dependency".
I see. Thanks for the reference.
Deprecate the repository rule for the OS library.
Towards #17231.
This change is