[workspace] Withdraw stable API support for several externals #17324
Conversation
jwnimmer-tri
added
priority: low
release notes: newly deprecated
|
+@rpoyner-tri for feature review, please. |
|
@rpoyner-tri what do you think about +(status: single reviewer ok)? |
jwnimmer-tri
added
the
status: single reviewer ok
There was a problem hiding this comment.
single is fine. Still looking.
Reviewed 50 of 50 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee rpoyner-tri(platform) (waiting on @jwnimmer-tri)
-- commits line 7 at r1:
grammar? missing words?
Code quote:
The python libraries either for maintainer-only code (github3, template),
or else brittle interior dependencies (clang) of private tools (mkdoc).
There was a problem hiding this comment.
Reviewable status: 2 unresolved discussions (waiting on @jwnimmer-tri)
a discussion (no related file):
Similar to a previous PR, are there names in tools/workspace/new_release.py that need updating?
These are the python- and models-only repositories that should not be public. The models already have Drake-public filegroup wrappers where appropriate. The python libraries are either maintainer-only code (github3, template), or else brittle interior dependencies (clang) of private tools (mkdoc).
jwnimmer-tri
force-pushed
the
workspace-internal
branch
from
104ed5e to
17d3e81
Compare
There was a problem hiding this comment.
Dismissed @rpoyner-tri from a discussion.
Reviewable status: 1 unresolved discussion (waiting on @rpoyner-tri)
a discussion (no related file):
Previously, rpoyner-tri (Rick Poyner (rico)) wrote…
Similar to a previous PR, are there names in
tools/workspace/new_release.pythat need updating?
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform) (waiting on @jwnimmer-tri)
These are the python- and models-only repositories that should not be public.
The models already have Drake-public filegroup wrappers where appropriate, in the
@drake//namespace.The python libraries are either for maintainer-only code (github3, uritemplate), or else brittle interior dependencies (clang) of Drake-private tools (mkdoc).
Relates to #17231 in the sense of a uniform stable / internal policy, even though there is no C/C++ code here.
This change is