Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Install libpython for consumers #17294

Merged
merged 1 commit into from
May 31, 2022

Conversation

svenevs
Copy link
Contributor

@svenevs svenevs commented May 31, 2022

Relates: #17161.

If consumers do a tar or deb install with --no-install-recommends
they will not be able to run the python code without libpython.


This change is Reviewable

Relates: RobotLocomotion#17161.

If consumers do a tar or deb install with --no-install-recommends
they will not be able to run the python code without libpython.
@svenevs svenevs added component: distribution Nightly binaries, monthly releases, docker, installation status: do not merge labels May 31, 2022
@svenevs
Copy link
Contributor Author

svenevs commented May 31, 2022

@drake-jenkins-bot linux-focal-unprovisioned-gcc-bazel-experimental-snopt-mosek-packaging please.
@drake-jenkins-bot linux-focal-unprovisioned-gcc-bazel-experimental-release please.

Blocked until the packaging job is complete and I can verify the resultant .tar.gz.

@svenevs svenevs mentioned this pull request May 31, 2022
10 tasks
@svenevs svenevs added release notes: fix This pull request contains fixes (no new features) and removed status: do not merge status: do not review labels May 31, 2022
Copy link
Contributor Author

@svenevs svenevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-(status: do not merge) -(status: do not review) +(release notes: yes) (downstream consumers may have been working around this e.g., for docker or something)

+@mwoehlke-kitware for feature review please.

In a fresh focal container I extracted the .tar.gz from the packaging build for this PR and installed the vanilla packages (cat /opt/drake/share/drake/setup/packages-focal.txt | DEBIAN_FRONTEND=noninteractive TZ=America/NewYork xargs apt-get install -y --no-install-recommends), the packages-focal.txt determines what happens for apt now which is why we are fixing it via fixing the .tar.gz.

The expected error for drake-visualizer in a headless container is now achieved:

# /opt/drake/bin/drake-visualizer
qt.qpa.xcb: could not connect to display 
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, xcb.

Reviewable status: LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @mwoehlke-kitware)

Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers (waiting on @svenevs)

@mwoehlke-kitware
Copy link
Contributor

+@rpoyner-tri for platform review, please.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),mwoehlke-kitware (waiting on @svenevs)

@rpoyner-tri rpoyner-tri merged commit 7d5edd2 into RobotLocomotion:master May 31, 2022
@svenevs svenevs deleted the fix/install-libpython branch May 31, 2022 19:04
aykut-tri pushed a commit to aykut-tri/drake that referenced this pull request Jun 1, 2022
* [workspace] Install libpython for consumers

Relates: RobotLocomotion#17161.

If consumers do a tar or deb install with --no-install-recommends
they will not be able to run the python code without libpython.
hongkai-dai pushed a commit to hongkai-dai/drake that referenced this pull request Jun 6, 2022
* [workspace] Install libpython for consumers

Relates: RobotLocomotion#17161.

If consumers do a tar or deb install with --no-install-recommends
they will not be able to run the python code without libpython.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: distribution Nightly binaries, monthly releases, docker, installation release notes: fix This pull request contains fixes (no new features)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants